Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes eslint issues in sticky-header.js #693

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fixes eslint issues in sticky-header.js #693

merged 2 commits into from
Jan 28, 2025

Conversation

markconroy
Copy link
Member

Closes #691

@markconroy
Copy link
Member Author

@millnut were you happy with the PR besides the single vs double quote? If so, I think we can mark this as approved.

@markconroy markconroy requested a review from millnut January 28, 2025 09:13
@andybroomfield andybroomfield merged commit cd836e8 into 1.x Jan 28, 2025
9 of 11 checks passed
@finnlewis finnlewis mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millnut millnut millnut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix eslint issues in sticky-header.js
3 participants
@markconroy @millnut @andybroomfield