Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks for heading before printing it #530

Merged
merged 2 commits into from
Mar 19, 2024
Merged

checks for heading before printing it #530

merged 2 commits into from
Mar 19, 2024

Conversation

markconroy
Copy link
Member

Closes #529

justinepocock
justinepocock reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@justinepocock justinepocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the second tqqa file is but the actual check is fine.

templates/paragraphs/paragraph--localgov-call-out-box.html.twig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is golden!

@finnlewis finnlewis merged commit 294e737 into 1.x Mar 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinepocock justinepocock justinepocock approved these changes

@msayoung msayoung Awaiting requested review from msayoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The heading tag is printing whether there is content or not.
3 participants
@markconroy @justinepocock @finnlewis