Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported option: &lt;1000 - the "<" symbol isn't recognised correctly #4

Open
Crotha opened this issue Jan 8, 2023 · 5 comments

Comments

@Crotha
Copy link
Contributor

Crotha commented Jan 8, 2023

As said in the title: using the "<" symbol in the tab-name isn't recognised correctly.
The whole tab-name is: kmail:#sellbot,<1000

Oh, and the alias in the questlog isn't recognised either, with that note:
keeping-tabs: selly=kmail:#sellbot,<1000

I put it on top of the notes, above all other notes. Anything specific to do there?

Thank you =)

ETA: one more thing: the "sell" option is not run when running keeping tabs (without any arguments) - it does work with keeping tabs sell

@pstalcup
Copy link
Contributor

pstalcup commented Jan 8, 2023

Taking a look at this now, will push a fix in a few minutes :)

@Malibu-Stacey
Copy link
Member

Looks fixed? Feel free to reopen if not.

@Crotha
Copy link
Contributor Author

Crotha commented Feb 6, 2023

Just updated to the loathers-version, problem still exists:

JavaScript exception: Unsupported Option: &lt;1000

is when I try a tab named: kmail:#sellbot,<1000

The alias in the questlog doing nothing and the sell-tab having to be called separately also still exist.

@Crotha
Copy link
Contributor Author

Crotha commented Feb 6, 2023

I opened the PR: #5
as I saw when looking into the code what the problem is with the sell-tab.

When I tried this out, it now works - but there is a "funny" new-ish error:
JavaScript exception: Unsupported Option: &lt;2000

And I realised: This is from the smashy-alias, which reads: kmail:#smashbot,<2000
which is not a current tab-name (unlike sellbot, which is) -> The alias is read correctly, just the smaller-than symbol isn't.

Unfortunately I have no clue what to do there... maybe include the &lt; into the regex?

@Tokoeka
Copy link
Contributor

Tokoeka commented Jan 26, 2024

Just run keeping tabs for first time, and can confirm I also got this behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants