Fix issue#613 show more info to maker when an order is taken #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 1, 2025 23:52
Add to invoice_payment_request message: order ID and payment method.
On branch issue#613
Changes to be committed:
modified: locales/de.yaml
modified: locales/en.yaml
modified: locales/es.yaml
modified: locales/fa.yaml
modified: locales/fr.yaml
modified: locales/it.yaml
modified: locales/ko.yaml
modified: locales/pt.yaml
modified: locales/ru.yaml
modified: locales/uk.yaml
Add to someone_took_your_order message: order ID, fiat ammount and payment method. - Added logic to retrieve the currency symbol based on the order's fiat_code. - If a native currency symbol is found, it is used; otherwise, the fiat_code is used. - Passed the `currency` and `order` instance to the `sendMessage` function to be used in the buyer's notification. On branch issue#613 Changes to be committed: modified: bot/messages.ts modified: locales/de.yaml modified: locales/en.yaml modified: locales/es.yaml modified: locales/fa.yaml modified: locales/fr.yaml modified: locales/it.yaml modified: locales/ko.yaml modified: locales/pt.yaml modified: locales/ru.yaml modified: locales/uk.yaml
jessekalil
reviewed
Jan 2, 2025
Catrya
requested changes
Jan 2, 2025
- Improved clarity in bot messages. - Adjusted message formatting to align with the defined style. modified: locales/de.yaml modified: locales/en.yaml modified: locales/es.yaml modified: locales/fa.yaml modified: locales/fr.yaml modified: locales/it.yaml modified: locales/ko.yaml modified: locales/pt.yaml modified: locales/ru.yaml modified: locales/uk.yaml
grunch
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
utACK
Thanks for this valuable contribution @wolfie2023, for future contributions please sign you commits 😃
jessekalil
approved these changes
Jan 11, 2025
Catrya
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Hi @wolfie2023, your branch is outdated. Please rebase and fix the errors.
I'm getting this error:
bot/messages.ts:414:5 - error TS2322: Type 'string' is not assignable to type 'IFiat'.
414 currency =
~~~~~~~~
Found 1 error in bot/messages.ts:414
But I fixed it this way.
- currency =
- !!currency && !!currency.symbol_native
- ? currency.symbol_native
- : order.fiat_code;
+ const currencySymbol =
+ currency && currency.symbol_native ? currency.symbol_native : order.fiat_code;
- currency,
+ currency: currencySymbol,
I'm no expert, so maybe you can find a better way to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the messages invoice_payment_request and someone_took_your_order the id of the order that was taken, the fiat amount and the payment method