Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code quality #59

Merged
merged 5 commits into from
Aug 5, 2024
Merged

feat: code quality #59

merged 5 commits into from
Aug 5, 2024

Conversation

dni
Copy link
Member

@dni dni commented Aug 2, 2024

No description provided.

@motorina0 motorina0 self-requested a review August 5, 2024 08:27

desc = parse_obj_as(Max144Str, link.success_text)
return UrlAction(url=url, description=desc)
elif link.success_text:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for else if there is an return on top

@motorina0 motorina0 merged commit badc420 into main Aug 5, 2024
10 checks passed
@motorina0 motorina0 deleted the codequality branch August 5, 2024 09:49
@motorina0 motorina0 mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants