Add Decoder Extension - Update extensions.json

[bitkarrot]

add decoder extension

[motorina0]

The functionality is useful, but should it be an extension?

[bitkarrot]

its tiny. I made it because i didn't want to bother you guys and it was convenient. If you want to roll into core, that's cool by me too.

@motorina0 @dni

[dni]

added a pr to the extensions, after this i am fine with merging it.

bitkarrot/decoder#1

can you release and use a version with v, like v0.0.2

[bitkarrot]

@dni here is the latest with your PR merged, lmk if that is ok

https://github.com/bitkarrot/decoder/releases/tag/v0.0.5

[motorina0]

@bitkarrot just an idea, do you think this extension would be more accessible if it was served as a public page?
For example: https://demo.lnbits.com/decoder/check

Is there any reason for requesting a user login?

[bitkarrot]

Agree we should make the page accessible as a public page, similar to https://lightningdecoder.com/

where is the user login? its just an extension, there should be no login required? @motorina0

@bitkarrot just an idea, do you think this extension would be more accessible if it was served as a public page? For example: https://demo.lnbits.com/decoder/check

Is there any reason for requesting a user login?

[bitkarrot]

About the public page - it might be good to make this an opt in or out, as a bot could come along and just spam the input box relentlessly.

[bitkarrot]

Had a brief chat with @motorina0

we're just gonna leave the decoder extension as-is. If there is nothing else you need fixed, please to add?

[motorina0]

CI failing at check-json

[bitkarrot]

CI failing at check-json

fixed check-json but jmeter is failing, also fails on lncalendar pr, unclear why

1722580508975,1440,Fetch vetted extension list,404,Not Found,Thread Group 1-1,text,false,"Test failed: code expected to equal /

[motorina0]

CI failing at check-json

ah, its because the PR is from a different repo (bitkarrot:patch-1), but it tries to find the branch on this repo

https://raw.githubusercontent.com/lnbits/lnbits-extensions/patch-1/extensions.json

@dni can you please have a look

[motorina0]

All good except the CI fix which is not related to this PR, but to the fact that an external repo is used.

[bitkarrot]

updated branch LFG!!

[talvasconcelos]

I'd bet we had decode endpoint in the core API...

[bitkarrot]

Whooops i just squashed and merged, i thought it was just merge :O

[motorina0]

Whooops i just squashed and merged, i thought it was just merge :O

All good! Congrats on the extension!