Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce Label component #DS-1566 #1905

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Feb 3, 2025

Description

Additional context

Issue reference

Separate Label field subcomponent | Web React

- Checkbox, FileUploader, Modal, Radio, Select, TextFieldBase, Slider, Toggle components are updated to use Label component
@pavelklibani pavelklibani self-assigned this Feb 3, 2025
@pavelklibani pavelklibani force-pushed the feat/ds-1566-label-component branch from d0e52dd to 451e6cf Compare February 3, 2025 17:00
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d0e52dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a0f611bbfbb90008721acd
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 451e6cf
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67a0f61fd68bdf0008bf57fc
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 451e6cf
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a0f61ee4bffd000881e51f
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator

literat commented Feb 3, 2025

Please, move the Label component into the Field directory where are also ValidationText and HelperText placed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants