Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/deps migrate typescript v5 #1900

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Chore/deps migrate typescript v5 #1900

wants to merge 9 commits into from

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 3, 2025

Description

Additional context

Issue reference

@literat
Deps: Upgrade TypeScript to v5
b3beda5
@literat
Chore(exporters): Extend base tsconfig instead of dom
a159cd5 
  * the scripts are not supposed to be used in the browser environment
@literat
Refactor(form-validations): Suggest better type for input element
2dfafbc
@literat
Chore(web): Use Jest setup file to extend matchers
de2bcb4
@literat
Chore(typescript-config): Fix @testing-library/jest-dom types path
206b7df 
  * types can be found in `../../node_modules/@testing-library/jest-dom`
  * the path is concatenated
@literat
fixup! Chore(web): Use Jest setup file to extend matchers
3a7e29e
@literat
Refactor(web-react): Remove JSXElementConstructor from elementType
2fc8a88 
  * it allows passing SVG element
@literat
Refactor(web-react): Define SpacingType for spacing prop
de10358
@literat
fixup! Refactor(web-react): Remove JSXElementConstructor from element…
e24c4d0 
…Type
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Feb 3, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit e24c4d0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a09405302e340008257b03
😎 Deploy Preview https://deploy-preview-1900--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit e24c4d0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67a094058226c80008cbc396
😎 Deploy Preview https://deploy-preview-1900--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova will be requested when the pull request is marked ready for review katerinarehorkova is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna will be requested when the pull request is marked ready for review adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen will be requested when the pull request is marked ready for review crishpeen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@literat literat

Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@literat