Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Remove duplicated id on the DropdownTrigger component #1893

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix(web-react): Remove duplicated id on the DropdownTrigger component #1893

merged 1 commit into from
Jan 30, 2025
+0 −1

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 28, 2025

Description

Removing id attribute from DropdownTrigger

Additional context

Issue reference

#1892

@github-actions github-actions bot added the bug Something isn't working label Jan 28, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d570e52
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679b74b5f056580009bdf463
😎 Deploy Preview https://deploy-preview-1893--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d570e52
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679b74b5de74060008f5d614
😎 Deploy Preview https://deploy-preview-1893--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the fix/1892-duplicated-dropdown-id branch from e2f2c77 to 0814fad Compare January 29, 2025 09:36
@coveralls
Copy link

coveralls commented Jan 29, 2025 •
edited
Loading

Coverage Status

coverage: 79.469%. remained the same
when pulling 696f9dc on fix/1892-duplicated-dropdown-id
into bad4fba on main.

@literat literat marked this pull request as ready for review January 29, 2025 12:00
@literat literat added the run-visual-tests Runs visual regression testing on this PR label Jan 29, 2025
@literat literat force-pushed the fix/1892-duplicated-dropdown-id branch from 0814fad to 696f9dc Compare January 29, 2025 13:12
@literat literat requested a review from adamkudrna as a code owner January 30, 2025 09:29
@literat literat force-pushed the fix/1892-duplicated-dropdown-id branch from 696f9dc to d570e52 Compare January 30, 2025 12:46
@literat literat merged commit de515f4 into main Jan 30, 2025
29 checks passed
@literat literat deleted the fix/1892-duplicated-dropdown-id branch January 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj curdaj approved these changes

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@literat literat

Labels
bug Something isn't working run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@literat @coveralls @crishpeen @pavelklibani @curdaj