Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(web-react): Card use DirectionExtended Dictionary #1878

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

pavelklibani
Copy link
Contributor

Description

Card now use dictionary DirectionExtended for direction prop

Additional context

Issue reference

Use DirectionExtended dictionary in Card

@pavelklibani pavelklibani self-assigned this Jan 27, 2025
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Jan 27, 2025
@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Jan 27, 2025
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 01dda7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679a24c0861aff000896afe0
😎 Deploy Preview https://deploy-preview-1878--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 27, 2025

👷 Deploy Preview for spirit-design-system-storybook processing.

Name Link
🔨 Latest commit 022e102
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679766f1ac16230009b0785b

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 01dda7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679a24c0ac1fe8000888c392
😎 Deploy Preview https://deploy-preview-1878--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani marked this pull request as ready for review January 27, 2025 11:05
@coveralls
Copy link

coveralls commented Jan 28, 2025

Coverage Status

coverage: 79.469%. remained the same
when pulling 01dda7f on refactor/ds-1649-card-use-direction-extended
into bad4fba on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj
Copy link
Contributor

curdaj commented Jan 29, 2025

Good job 👍

@pavelklibani pavelklibani merged commit 214ef37 into main Jan 29, 2025
29 checks passed
@pavelklibani pavelklibani deleted the refactor/ds-1649-card-use-direction-extended branch January 29, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants