-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce Skeleton component #DS-1625 #1863
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👏 Great, nice first PR and contribution to the Spirit Design System 🎉 When I switch the demo to the "Light on brand" theme, the animation and color are missing. I think that this should be the same as the default. But not sure. @crishpeen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job. LGTM 👍 Please wait for the merge after approval by @crishpeen or @adamkudrna. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work, I am sorry I have a lot of comments, especially because a lot of them is something which might be opinionated.
Sometimes I just raised a question where I am not sure about something.
Please also add a visual screenshot when the PR is ready again (there will actually be two - new web HP and the acutal Skeleton). Thank you very much and feel free to ask for more explanation if I am not clear somewhere!
9c234ee
to
df3917c
Compare
It is looking good with the new tokens. Great work. I have only one question regarding the animation: Can it be more smooth, please? Now it looks like there is a little jump or hiccup between the end and the start of the loop. I am not sure if this is understandable but if I compare the animation with the https://design-system.seduo.com/docs/components/skeleton, the animation starts and ends in the same position, e.g. no gradient is displayed. But in our case, we are starting with a displayed gradient at the start of the Skeleton and we end the ease with the displayed gradient at the end. So when the loop restarts there is a little "hiccup" in the animation. 🔝 @crishpeen But if we have agreed on this, maybe it is fine 🤷 |
Description
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1625