Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Introduce UNSTABLE Header & Navigation #1808

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Feat: Introduce UNSTABLE Header & Navigation #1808

wants to merge 23 commits into from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6e23b99
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679a2c92bf76a300088f74f9
😎 Deploy Preview https://deploy-preview-1808--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6e23b99
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679a2c923dea810008dc9ed0
😎 Deploy Preview https://deploy-preview-1808--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR feature New feature or request labels Dec 10, 2024
@crishpeen crishpeen force-pushed the integration/header branch 2 times, most recently from e1a591b to fbe9985 Compare December 17, 2024 12:53
@crishpeen crishpeen mentioned this pull request Dec 17, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12373418568/artifacts/2331849796

@coveralls
Copy link

coveralls commented Jan 8, 2025 •
edited
Loading

Coverage Status

coverage: 79.469%. remained the same
when pulling 6e23b99 on integration/header
into 2b5daa9 on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12670274898/artifacts/2401147495

crishpeen and others added 16 commits January 28, 2025 12:54
@crishpeen
Feat(web): Introduce UNSTABLE Header component #DS-1523
e520c40
@crishpeen
Feat(web): Introduce Navigation and NavigationLink components #DS-155…
e8a14b0 
…1 #DS-1530
@curdaj @crishpeen
Feat(web-react): Introduce UNSTABLE_Header #DS-1524
6e495df
@curdaj @crishpeen
Feat(web-react): Introduce Navigation #DS-1524
be9db49
@crishpeen
Fix(web): Rename NavigationLink component to NavigationAction
2be475f
@crishpeen
Fix(web-react): Rename NavigationLink component to NavigationAction
7e558cb
@crishpeen
Test: Update Homepage Screenshots
e15404f
@curdaj @crishpeen
Feat(web-react): Introduce Drawer component #DS-1580
433795c
@curdaj @crishpeen
Feat(web): Introduce Drawer component #DS-1580
63c47ee
@crishpeen
Feat(web): Introduce alignment to Dropdown component #DS-1411
e289c4a
@crishpeen
Feat(web-react): Introduce alignment to Dropdown component #DS-1411
9a5c06c
@crishpeen
Feat(web-twig): Introduce alignment to Dropdown component #DS-1411
0c4e5e7
@crishpeen
Feat(web): Introduce button-unstyled helper
f619d4c
@crishpeen
Feat(web): Introduce NavigationItem subcomponent #DS-1411
9507130
@crishpeen
Feat(web-react): Introduce NavigationItem subcomponent #DS-1411
5afb856
@crishpeen
Docs(web): Showcase Header with Navigation and Dropdown #DS-1411
b3c98d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat will be requested when the pull request is marked ready for review literat is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna will be requested when the pull request is marked ready for review adamkudrna is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova will be requested when the pull request is marked ready for review katerinarehorkova is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @curdaj