-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM_ENABLE_RUNTIMES=flang-rt for amdgpu-offload-* #402
Conversation
Unfortunately, the annotated builders are impossible to check locally using instructions from https://llvm.org/docs/HowToAddABuilder.html#testing-a-builder-config-locally, as the build instructions are taken directly from multiple main directories on github.com:
Running the unchanged/
I think this is because The in-production buildbot workers may not see the issue because the |
I have a setup for local testing and can take a swing at it for a test. |
That is not quite the intended behavior, but after looking at the code, I believe you are right. Let me put up a patch that does what it should do more reasonably. |
As pointed out in llvm#402 the former solution deleted the CWD from within that directory, rendering the state quite useless and resulting in errors on execution. The approach in here creates a temp directory, changes to it, removes the old CWD, recreates it, and changes back to that directory. I opted for this solution as, oddly enough, I had some trouble removing the enumerated list of files in the buildtree.
As pointed out in #402 the former solution deleted the CWD from within that directory, rendering the state quite useless and resulting in errors on execution. The approach in here creates a temp directory, changes to it, removes the old CWD, recreates it, and changes back to that directory. I opted for this solution as, oddly enough, I had some trouble removing the enumerated list of files in the buildtree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depending on the activity with the flang-rt
, we may want to land this prior to the change to the CMake cache, such that the scheduler is already aware of the dependency.
…129692) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402
…-offload-* (#129692) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402
…ffload-*" (#130274) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402 This reverts commit e296fb8. The worker of amdgpu-offload-rhel-8-cmake-build-only has been updated with a newer version of Ninja that supports Fortran.
…or amdgpu-offload-*" (#130274) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402 This reverts commit e296fb8. The worker of amdgpu-offload-rhel-8-cmake-build-only has been updated with a newer version of Ninja that supports Fortran.
…ffload-*" (llvm#130274) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402 This reverts commit e296fb8. The worker of amdgpu-offload-rhel-8-cmake-build-only has been updated with a newer version of Ninja that supports Fortran.
…lvm#129692) Enable the LLVM_ENABLE_RUNTIMES=flang-rt build of the Fortran runtime for the amdgpu-offload-* buildbots. This pre-population cmake cache files is referred to by the llvm-zorg annotated builder factory [script](https://github.com/llvm/llvm-zorg/blob/872f477610d83821c9f1368c969006789b21011b/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py#L26). The corresponding change in llvm-zorg is llvm/llvm-zorg#402
Add
depends_on_projects=['flang-rt']
, andchecks=['check-flang-rt']
to the amdgpu-offload-* builders. The prepares the removal of the "projects" build of the flang runtime in llvm/llvm-project#124126.The corresponding change in the LLVM repository is llvm/llvm-project#129692
Affected builders (production):
Affected workers (production):
Admins listed for those workers: