Skip to content

[MLIR] tosa.rescale op validation incorrectly fails on unsigned integer type #135699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samvid25 opened this issue Apr 14, 2025 · 1 comment
Open

Comments

@samvid25
Copy link

See godbolt: https://godbolt.org/z/8z6Ycahnv
According to the TOSA Spec (here), unsigned 8 and 16-bit types are allowed in the RESCALE operation. The TOSA dialect docs specify the same as well (here).

@llvmbot llvmbot added the mlir label Apr 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 14, 2025

@llvm/issue-subscribers-mlir

Author: Samvid Dharanikota (samvid25)

See godbolt: https://godbolt.org/z/8z6Ycahnv According to the TOSA Spec ([here](https://www.mlplatform.org/tosa/tosa_spec.html#_integer_behavior)), unsigned 8 and 16-bit types are allowed in the RESCALE operation. The TOSA dialect docs specify the same as well ([here](https://github.com/llvm/llvm-project/blob/76db259080fa134579f31d76fe9ab462f47eca87/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td#L2360)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants