Add polymer2 #360

vatai · 2023-09-15T01:07:00Z

No description provided.

chelini

I did a rapid pass on the PR. I would like to understand if we need all the files in example and example/handwritten. What is the purpose of this directory? Can we preserve only the .c and .h files and remove all the logs and mlir ones?

chelini · 2023-09-15T12:37:29Z

tools/polymer/tools/polymer-translate/polymer-translate.cc

@@ -0,0 +1,117 @@
+//===- polymer-translate.cc---------------------------------------*- C++
+//-*-===//


nit, missing clang-format?

chelini · 2023-09-15T12:40:46Z

tools/polymer/example/polybench/split-and-merge/trmm/trmm.nosplit.polymer.seq.log

@@ -0,0 +1,228 @@
+Pluto schedule elapsed time: 8.184383e-02s


Are all these .log files needed?

chelini · 2023-09-15T12:43:38Z

...polymer/example/polybench/split-and-merge/correlation/correlation.heuristic.polymer.par.mlir

@@ -0,0 +1,417 @@
+#map0 = affine_map<(d0) -> (d0)>


What is the purpose of this example directory? I see .c and .h files, which may remain, but I would remove the log files and the mlir ones.

chelini · 2023-09-15T12:44:46Z

tools/polymer/example/polybench/EXTRALARGE/3mm/polybench.i

@@ -0,0 +1,5044 @@
+# 1 "/home/ubuntu/polymer/example/polybench/utilities/polybench.c"


what is this?

chelini · 2023-09-15T12:45:14Z

tools/polymer/example/handwritten/nussinov.pluto_llvm.mlir

@@ -0,0 +1,3 @@
+module attributes {llvm.data_layout = ""}  {


empty module, remove? There are multiple files.

chelini · 2023-09-15T12:45:59Z

tools/polymer/example/handwritten/nussinov.pluto.c

@@ -0,0 +1,109 @@
+// File name: main.c


what is the purpose of this handwritten directory?

this is a @kumasento question if you know the answer offhand. (right now this is a first pass to merge the repos while preserving history and getting it to build)

Fair point, we can iterate on this later.

chelini · 2023-09-15T12:46:47Z

tools/polymer/.github/workflows/buildAndTest.yml

+          git submodule init
+          git submodule update --recursive --init
+
+      # - name: Link Polymer into Polygeist


nit, I would remove commented code if not needed. Here and below

chelini · 2023-09-15T12:49:02Z

tools/polymer/example/polybench/EXTRALARGE/adi/adi.c

+  return 0;
+}
+
+// CHECK: #map0 = affine_map<()[s0] -> (s0 + 1)>


This was of checking IR is fragile. I can help fixing it if we decide to merge.

* Setup the infra for emitting openscop * Implemented a draft version * Added LIT regression test framework * Refactorized OpenScop generation by osl library. * Supported adding a single parameter * Supported imperfectly nested loops * Added a new testcase for affine.if * Added a simple test case for local vars. * Improved code quality * Updated LLVM commit * Replaced duplicated swapId with upstream * Added body/arrays extensions to support PLUTO * Added parameter name list to scop

* Generate MLIR from OpenScop * Added simple unittests and fixed the old ones * Removed redundant comments

* Initial implementation of store-based OpenScop transform * Fixed (partially) unit tests

* Fixed flatExprs -> access relation & added matmul. * Force using ISL dep calculation in Pluto

* Added dep tiling testcase * Handles min/max in bounds & term def at apply.

[PlutoTransform] canonicalize after dedup cast [PlutoTransform] fix dedup segfault

[FoldSCFIf] scalrep before folding [FoldSCFIf] scalrep before folding

ivanradanov · 2023-11-23T23:35:21Z

List of things I changed when I was rebasing polymer to the latest llvm-project, and was not sure the new thing does exactly the same thing as the old, we should probably confirm:

  getEnclosingAffineForAndIfOps 
  ->
  getEnclosingAffineOps

(fixed)
  ctx.reset(/*numDims=*/0, /*numSymbols=*/symbols.size());
  ->
  ctx = affine::FlatAffineValueConstraints();

  mlir::affine::AffineParallelOp newPloop = b.create<mlir::affine::AffineParallelOp>(
      loc, llvm::None, llvm::None, lowerBoundMap, lowerBoundOperands,
      upperBoundMap, upperBoundOperands, 1);
  ->
  mlir::affine::AffineParallelOp newPloop = b.create<mlir::affine::AffineParallelOp>(
      loc, TypeRange(), ArrayRef<arith::AtomicRMWKind>(), lowerBoundMap, lowerBoundOperands,
      upperBoundMap, upperBoundOperands, 1);


  llvm::cl::opt<const TranslationFunction *, false, TranslationParser>
      translationRequested("", llvm::cl::desc("Translation to perform"),
                           llvm::cl::Required);
  ->
  llvm::cl::opt<const Translation *, false, TranslationParser>
      translationRequested("", llvm::cl::desc("Translation to perform"),
                           llvm::cl::Required);

ivanradanov · 2023-12-11T18:25:21Z

Now we have separate polymer and non-polymer builds.

Crashes in the tests have been fixed, now we would actually have to look into the test outputs and fix the checks up (or XFAIL them and leave them as todo?)

ivanradanov · 2024-01-01T00:20:45Z

It works on my machine...

Co-authored-by: Emil VATAI <emil.vatai@gmail.com> Co-authored-by: William Moses <gh@wsmoses.com>

wsmoses requested review from ftynse, kumasento, chelini and ivanradanov September 15, 2023 01:07

kumasento approved these changes Sep 15, 2023

View reviewed changes

chelini reviewed Sep 15, 2023

View reviewed changes

kumasento and others added 24 commits November 3, 2023 09:06

Initial commit

23da8e7

Added LLVM submodule and install instructions

ec5c77e

Added PLUTO as submodule and its install insts.

2c2b4ee

Update README.md

f6e0afd

Generate MLIR from OpenScop (#2)

7a52c2f

* Generate MLIR from OpenScop * Added simple unittests and fixed the old ones * Removed redundant comments

Added InvariantScopTransform and polymer-opt (#3)

9211953

Initial implementation of store-based OpenScop transform (#4)

e86ef4a

* Initial implementation of store-based OpenScop transform * Fixed (partially) unit tests

Added missing clast_binary to AffineExpr translation (#9)

e634519

Added PLUTO to the compilation flow (#10)

71207a2

Changed PLUTO compilation & created opt pass (#13)

a168d22

Added a transpose test case for nested loops (#18)

85848b3

Fixed the issue with <scatnames> (#20)

4968986

Fixed problems in generating loop bounds with outer IVs (#21)

0920097

Enables pluto tiling for simple cases (#22)

525c215

Added side effect guards when adding def ops (#23)

83cd745

Refactorized polymer-translate interface (#24)

8324ea7

Improved the scatnames mapping for Scops from PLUTO (#25)

ac02231

Fixed flatExprs -> access relation & added matmul. (#30)

a5fda8b

Force using ISL dep calculation in Pluto (#33)

5df356b

* Fixed flatExprs -> access relation & added matmul. * Force using ISL dep calculation in Pluto

Handles min/max in loop bounds & terminates defOps at affine.apply (#36)

6ce84d1

* Added dep tiling testcase * Handles min/max in bounds & term def at apply.

Build robust mapping from iterators to scatnames (#37)

993ab3c

Updated install instructions & fixed Pluto include (#43)

073811d

Update README.md to include TeX dependence

8825552

kumasento and others added 14 commits November 3, 2023 09:06

[PlutoTransform] can handle index at top-level

e7085c2

[PlutoTransform] fix symbol alignment

4315a54

[PlutoTransform] canonicalize and segfault fix

91ab758

[PlutoTransform] canonicalize after dedup cast [PlutoTransform] fix dedup segfault

[FoldSCFIf] won't apply for scop.ignored

4653d02

[PlutoTransform] fix attrs

7f6dbb9

[FoldSCFIf] scalrep before folding

983becc

[FoldSCFIf] scalrep before folding [FoldSCFIf] scalrep before folding

Fix

8ffcabc

Update README.md

3bb1164

[README] update matmul example

2b7bf0b

Update polygeist-version.txt

13d5bdf

Support Polygeist e5b8b83

97bc4e3

Updated build script

78d38fe

Bump polygeist to 6ba6b7b

6954e0b

Fix script name in installation instructions

73bc39b

ivanradanov force-pushed the add-polymer2 branch 2 times, most recently from e62a3dd to 418f280 Compare November 3, 2023 05:05

ivanradanov force-pushed the add-polymer2 branch 3 times, most recently from fa3538f to da8784d Compare December 11, 2023 17:53

ivanradanov force-pushed the add-polymer2 branch 3 times, most recently from 5ffba6b to 491f8b6 Compare January 15, 2024 05:22

ivanradanov force-pushed the add-polymer2 branch from 936cb99 to 0fbde52 Compare January 24, 2024 23:58

Integrate Polymer into Polygeist

fad38d6

Co-authored-by: Emil VATAI <emil.vatai@gmail.com> Co-authored-by: William Moses <gh@wsmoses.com>

ivanradanov force-pushed the add-polymer2 branch from 0fbde52 to fad38d6 Compare January 25, 2024 00:39

ivanradanov merged commit 4b04755 into main Jan 25, 2024
9 checks passed

wsmoses deleted the add-polymer2 branch January 25, 2024 00:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add polymer2 #360

Add polymer2 #360

vatai commented Sep 15, 2023

chelini left a comment

chelini Sep 15, 2023

chelini Sep 15, 2023

chelini Sep 15, 2023

chelini Sep 15, 2023

chelini Sep 15, 2023 •

edited

Loading

chelini Sep 15, 2023

wsmoses Sep 15, 2023

chelini Sep 15, 2023

chelini Sep 15, 2023

chelini Sep 15, 2023

ivanradanov commented Nov 23, 2023 •

edited

Loading

ivanradanov commented Dec 11, 2023

ivanradanov commented Jan 1, 2024

		@@ -0,0 +1,117 @@
		//===- polymer-translate.cc---------------------------------------*- C++
		//-*-===//

		@@ -0,0 +1,5044 @@
		# 1 "/home/ubuntu/polymer/example/polybench/utilities/polybench.c"

Add polymer2 #360

Add polymer2 #360

Conversation

vatai commented Sep 15, 2023

chelini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chelini Sep 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivanradanov commented Nov 23, 2023 • edited Loading

ivanradanov commented Dec 11, 2023

ivanradanov commented Jan 1, 2024

chelini Sep 15, 2023 •

edited

Loading

ivanradanov commented Nov 23, 2023 •

edited

Loading