Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #416 extra_options cannot give None as value #438

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix #416 extra_options cannot give None as value #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ef9cd
fix
lucemia Feb 6, 2025
2e42e22
fix
lucemia Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ffmpeg/dag/global_runnable/global_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from abc import ABC, abstractmethod
from typing import TYPE_CHECKING, Any

from ...types import Boolean, Float, Func, Int
from ...types import Boolean, Float, Func, Int, Value

if TYPE_CHECKING:
from ..nodes import GlobalNode, GlobalStream, OutputStream
Expand Down Expand Up @@ -63,7 +63,7 @@ def global_args(
adrift_threshold: Func = None,
qphist: Func = None,
vsync: Func = None,
extra_options: dict[str, Any] = None,
extra_options: dict[str, Value] = None,
) -> GlobalStream:
"""
Set global options.
Expand Down
5 changes: 2 additions & 3 deletions src/ffmpeg/dag/io/_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@


from pathlib import Path
from typing import Any

from ...streams.av import AVStream
from ...types import Boolean, Double, Float, Int, String, Time
from ...types import Boolean, Double, Float, Int, String, Time, Value
from ..nodes import InputNode


Expand Down Expand Up @@ -64,7 +63,7 @@ def input(
dcodec: String = None,
dn: Boolean = None,
top: Int = None,
extra_options: dict[str, Any] = None,
extra_options: dict[str, Value] = None,
) -> AVStream:
"""
Input file URL (ffmpeg ``-i`` option)
Expand Down
5 changes: 2 additions & 3 deletions src/ffmpeg/dag/io/_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@


from pathlib import Path
from typing import Any

from ...types import Boolean, Float, Func, Int, Int64, String, Time
from ...types import Boolean, Float, Func, Int, Int64, String, Time, Value
from ..nodes import FilterableStream, OutputNode, OutputStream


Expand Down Expand Up @@ -105,7 +104,7 @@ def output(
dcodec: String = None,
dn: Boolean = None,
top: Int = None,
extra_options: dict[str, Any] = None,
extra_options: dict[str, Value] = None,
) -> OutputStream:
"""
Output file URL
Expand Down
6 changes: 3 additions & 3 deletions src/ffmpeg/dag/io/output_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

from abc import ABC, abstractmethod
from pathlib import Path
from typing import TYPE_CHECKING, Any
from typing import TYPE_CHECKING, Any, Mapping

from ...types import Boolean, Float, Func, Int, Int64, String, Time
from ...types import Boolean, Float, Func, Int, Int64, String, Time, Value

if TYPE_CHECKING:
from ..nodes import FilterableStream, OutputNode, OutputStream
Expand Down Expand Up @@ -114,7 +114,7 @@ def output(
dcodec: String = None,
dn: Boolean = None,
top: Int = None,
extra_options: dict[str, Any] = None,
extra_options: Mapping[str, Value] = None,
) -> OutputStream:
"""
Output file URL
Expand Down
Loading
Loading