Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private method `set_output' called for #<LiveKit::EgressServiceClient:0x000055f15cca5cf8> #39

Open
izinko opened this issue Oct 27, 2023 · 1 comment
Open

private method `set_output' called for #<LiveKit::EgressServiceClient:0x000055f15cca5cf8> #39

izinko opened this issue Oct 27, 2023 · 1 comment

Comments

@izinko
Copy link

izinko commented Oct 27, 2023

private method set_output' called for #<LiveKit::EgressServiceClient:0x000055f15cca5cf8> .rvm/gems/ruby-2.6.1@immerss-portal/gems/livekit-server-sdk-0.6.1/lib/livekit/egress_service_client.rb:42:in start_room_composite_egress'

I think in this case it must use set_output(request, output) instead self.set_output(request, output) in whole lib/livekit/egress_service_client.rb file
@davidzhao
Copy link
Member

You are right. That looks like a bug.. would you like to create a PR for it?

@izinko izinko mentioned this issue Nov 7, 2023
Closed
izinko added a commit to izinko/server-sdk-ruby that referenced this issue Nov 7, 2023
@izinko
fix exception private method set_output' called for #<LiveKit::Egress…
45b6ffc 
…ServiceClient:0x000055f15cca5cf8> :42

fix issue livekit#39 livekit#39
@izinko izinko mentioned this issue Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidzhao @izinko