spi_nor_flash_module.py: fix read_cmds array #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds modes for W25Q128JV. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
fix ValueError content Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
If more that one module is used with incompatible read_cmds, it leads to a a raised ValueError (Read command ... not supported in chip ...). This fixes it so the different modules wont share a common read_cmds array if that is not explicitly defined. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
|
Thanks @maass-hamburg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@enjoy-digital
If more that one module is used with incompatible read_cmds, it leads to a a raised ValueError (Read command ... not supported in chip ...).
This fixes it so the different modules wont share a common read_cmds array if that is not explicitly defined.
also adds modes for the W25Q128JV.