-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-19308 - feat(databricks): ensure essential table properties Delta.* #233
base: main
Are you sure you want to change the base?
Conversation
src/main/java/liquibase/ext/databricks/sqlgenerator/CreateTableGeneratorDatabricks.java
Outdated
Show resolved
Hide resolved
src/main/java/liquibase/ext/databricks/sqlgenerator/CreateTableGeneratorDatabricks.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Had a concern about wrapping of properties key/value in quotes, but acccording to tests logic uses existing user specified approach and default values are wrapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlesQueiroz we need to update expected SQL-s, see failed harness tests.
…reserved in TBLPROPERTIES clause Added logic to maintain essential Delta properties when creating tables, ensuring critical parameters are always present with appropriate values, whether user-specified or defaults.
e52d3fd
to
6dd2ef1
Compare
bfb9e90
to
92b5816
Compare
Quality Gate passedIssues Measures |
Overview
This PR addresses the handling of essential Delta table properties in the Databricks extension, specifically ensuring critical properties are always included in table creation statements regardless of user input.
Problem
Previously, when users specified custom TBLPROPERTIES during table creation, the system would not guarantee the presence of essential Delta properties.
Solution
The implementation introduces a property management system that:
Key Changes
processTableProperties
methodTesting
The changes are covered by unit tests that verify: