Merge pull request #236 from liquibase/DAT-19349

DAT-19349: Revised and updated harness tests, enabled some missing suites, extended and updated expected snapshots.

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/addCheckConstraint.json

@@ -1,3 +1,14 @@
 {
-
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "posts",
+            "tblProperties": ".*'delta.constraints.test_check_constraint'='id > 0'.*"
+          }
+        }
+      ]
+    }
+  }
 }

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/addDefaultValue.json

@@ -0,0 +1,24 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "posts"
+          }
+        }
+      ],
+      "liquibase.structure.core.Column": [
+        {
+          "column": {
+            "name": "title",
+            "type": {
+              "typeName": "VARCHAR"
+            },
+            "defaultValue": "title_test"
+          }
+        }
+      ]
+    }
+  }
+}

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/addDefaultValueBoolean.json

@@ -0,0 +1,17 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Column": [
+        {
+          "column": {
+            "name": "booleanColumn",
+            "type": {
+              "typeName": "BOOLEAN"
+            },
+            "defaultValue": "TRUE"
+          }
+        }
+      ]
+    }
+  }
+}

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/addDefaultValueComputed.json

@@ -0,0 +1,18 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Column": [
+        {
+          "column": {
+            "name": "inserted_date",
+            "type": {
+              "typeName": "DATE"
+            },
+            "defaultValue": "CURRENT_TIMESTAMP",
+            "nullable": true
+          }
+        }
+      ]
+    }
+  }
+}

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/addDefaultValueDate.json

@@ -0,0 +1,18 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Column": [
+        {
+          "column": {
+            "name": "dateTimeColumn",
+            "type": {
+              "typeName": "TIMESTAMP"
+            },
+            "defaultValue": "'2008-02-12 12:34:03'",
+            "nullable": true
+          }
+        }
+      ]
+    }
+  }
+}

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/alterCluster.json

@@ -1,2 +1,14 @@
 {
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "test_table_alter_cluster",
+            "clusteringColumns": "test_id,test_new"
+          }
+        }
+      ]
+    }
+  }
 }

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/alterTableProperties.json

@@ -1,3 +1,14 @@
 {
-
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "test_alter_table_properties",
+            "tblProperties": ".*'external.location'='s3://mybucket/mytable', 'this.is.my.key'='12', 'this.is.my.key2'='true'.*"
+          }
+        }
+      ]
+    }
+  }
 }

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/alterViewProperties.json

@@ -1,3 +1,14 @@
 {
-
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.View": [
+        {
+          "view": {
+            "name": "test_alter_view_properties",
+            "tblProperties": ".*'external.location'='s3://mybucket/mytable', 'this.is.my.key'='12', 'this.is.my.key2'='true'.*"
+          }
+        }
+      ]
+    }
+  }
 }

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/createClusteredTable.json

@@ -4,7 +4,8 @@
       "liquibase.structure.core.Table": [
         {
           "table": {
-            "name": "test_table_clustered"
+            "name": "test_table_clustered",
+            "clusteringColumns": "test_id"
           }
         }
       ],

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/createPartitionedTable.json

@@ -4,7 +4,8 @@
       "liquibase.structure.core.Table": [
         {
           "table": {
-            "name": "test_table_partitioned"
+            "name": "test_table_partitioned",
+            "partitionColumns": "partition_column"
           }
         }
       ],

src/test/resources/liquibase/harness/change/expectedSnapshot/databricks/dropCheckConstraint.json

@@ -1,3 +1,16 @@
 {
-
+  "snapshot": {
+    "objects": {
+      "_noMatch": true,
+      "_noMatchField": "tblProperties",
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "posts",
+            "tblProperties": ".*'delta.constraints.test_check_constraint'='id > 0'.*"
+          }
+        }
+      ]
+    }
+  }
 }

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValue.sql

@@ -1,3 +1 @@
-INVALID TEST
--- Databricks supports default values, but does not support them in snapshot data json
---ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN title SET DEFAULT 'title_test'
+ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN title SET DEFAULT 'title_test'

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValueBoolean.sql

@@ -1,3 +1,2 @@
-INVALID TEST
--- Databricks supports default values, but the object does not exist in the metadata
--- --ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN title SET DEFAULT false
+ALTER TABLE main.liquibase_harness_test_ds.authors ADD COLUMN booleanColumn BOOLEAN
+ALTER TABLE main.liquibase_harness_test_ds.authors ALTER COLUMN booleanColumn SET DEFAULT TRUE

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValueComputed.sql

@@ -1,2 +1 @@
-INVALID TEST
--- Databricks supports default values and generated columns, but the object does not exist in the metadata returned in jdbc
+ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN inserted_date SET DEFAULT CURRENT_TIMESTAMP

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValueDate.sql

@@ -1,3 +1,2 @@
-INVALID TEST
--- Databricks supports default values, but the object does not exist in the metadata
---ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN title SET DEFAULT false
+ALTER TABLE main.liquibase_harness_test_ds.authors ADD COLUMN dateTimeColumn TIMESTAMP
+ALTER TABLE main.liquibase_harness_test_ds.authors ALTER COLUMN dateTimeColumn SET DEFAULT '2008-02-12 12:34:03'

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValueNumeric.sql

@@ -1,3 +1,4 @@
 INVALID TEST
--- Databricks supports default values, but the object does not exist in the metadata
---ALTER TABLE main.liquibase_harness_test_ds.posts ALTER COLUMN title SET DEFAULT false
+-- Databricks does not support NUMBER type
+-- ALTER TABLE main.liquibase_harness_test_ds.authors ADD COLUMN numericColumn NUMBER
+-- ALTER TABLE main.liquibase_harness_test_ds.authors ALTER COLUMN numericColumn SET DEFAULT 100000000

src/test/resources/liquibase/harness/change/expectedSql/databricks/addDefaultValueSequenceNext.sql

@@ -1 +1,2 @@
-INVALID TEST
+INVALID TEST
+--Database databricks does not support sequences

src/test/resources/liquibase/harness/change/expectedSql/databricks/createFunction.sql

@@ -1,2 +1,2 @@
 INVALID TEST
--- Databricks supports functions, but this can only be done in liquibase PRO
+-- Databricks supports functions, but this can only be done in Databricks commercial extension

src/test/resources/liquibase/harness/change/expectedSql/databricks/enableTrigger.sql

@@ -1,2 +1,2 @@
 INVALID TEST
-Databricks does not support the concept of triggers
+--Databricks does not support the concept of triggers

src/test/resources/liquibase/harness/change/expectedSql/databricks/renameTrigger.sql

@@ -1,2 +1,2 @@
 INVALID TEST
-Databricks does not support the concept of triggers
+--Databricks does not support the concept of triggers