fix: Add a variable for rsyslog base package on Debian #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrosi
reviewed
Feb 17, 2025
On RedHat, it's named "iproute" but on Debian based systems it's named "iproute2"
TheLastChosenOne
force-pushed
the
change_base_package_names_for_Ubuntu
branch
from
b31116c to
ccbdc38
Compare
spetrosi
changed the title
|
@TheLastChosenOne did you test it on Debian? |
|
|
[citest] |
spetrosi
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RedHat, it's named "iproute" but on Debian based systems it's named "iproute2"
Enhancement: Make this role functional again for Debian based systems
Reason: Newer version of this role (see commit 64f915a) included the package "iproute" which is named "iproute2" on Debian based systems.
Result: Define an own __rsyslog_base_packages list for Debian based systems
Issue Tracker Tickets (Jira or BZ if any):