Add pytest tests and a GitHub Actions workflow for SD register decoding #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Very nice.
This means #62 (comment) is done.
Once #62 is merged this has my approval.
jluebbe
force-pushed
the
test-workflow
branch
2 times, most recently
from
b994aa0 to
083ef47
Compare
jluebbe
changed the title
jluebbe
force-pushed
the
test-workflow
branch
from
083ef47 to
5bf64f2
Compare
SmithChart
previously approved these changes
Dec 20, 2023
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
force-pushed
the
test-workflow
branch
from
5bf64f2 to
d9fb32c
Compare
|
Rebased on #62. |
|
@jluebbe Please rebase |
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
force-pushed
the
test-workflow
branch
from
d9fb32c to
c962e73
Compare
|
Rebased. |
SmithChart
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #62.