Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and general project improvements #37

Closed
wants to merge 16 commits into from
Closed

Refactoring and general project improvements #37

wants to merge 16 commits into from

Conversation

doroxz-zz
Copy link
Member

@doroxz-zz doroxz-zz commented Oct 6, 2018

This huge update contains:

@xferra
Copy link
Contributor

xferra commented Oct 6, 2018

@doroxz I’d like to split this PR, please try to follow the rule ‘1 Issue = 1 PR = 1 Commit’ as much as possible.

@doroxz-zz
Copy link
Member Author

doroxz-zz commented Oct 6, 2018

@doroxz I’d like to split this PR, please try to follow the rule ‘1 Issue = 1 PR = 1 Commit’ as much as possible.

Well..

@doroxz-zz doroxz-zz closed this Oct 6, 2018
@xferra
Copy link
Contributor

xferra commented Oct 6, 2018

@doroxz Of course it’s possible to have several commits on 1 pr, but then it should belong to 1 feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants