Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8777] - Refactor CreateCluster component to use react-hook-form #11581

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

Description πŸ“

Highlight the Pull Request's context and intentions.

Changes πŸ”„

List any change(s) relevant to the reviewer.

  • ...
  • ...

Target release date πŸ—“οΈ

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview πŸ“·

Include a screenshot or screen recording of the change.

πŸ”’ Use the Mask Sensitive Data setting for security.

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
πŸ“· πŸ“·

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>

Commit Types:

  • feat: New feature for the user (not a part of the code, or ci, ...).
  • fix: Bugfix for the user (not a fix to build something, ...).
  • change: Modifying an existing visual UI instance. Such as a component or a feature.
  • refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
  • test: New tests or changes to existing tests. Does not change the production code.
  • upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history


@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 8 failing tests on test run #2 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
8 Failing480 Passing2 Skipped126m 3s

Details

Failing Tests
SpecTest
❌lke-create.spec.tsLKE Cluster Creation » can create an LKE cluster
❌lke-create.spec.tsLKE Cluster Creation with APL enabled » can create an LKE cluster with APL flag enabled
❌lke-create.spec.tswith LKE IPACL account capability » creates an LKE cluster with ACL disabled
❌lke-create.spec.tswith LKE IPACL account capability » creates an LKE cluster with ACL enabled
❌lke-create.spec.tswith LKE IPACL account capability » can handle validation and API errors
❌smoke-lke-create.spec.tsLKE Create Cluster » Simple Page Check
❌plan-selection.spec.tsdisplays kubernetes plans panel based on availability » displays the proper plans based on the region and types
❌plan-selection.spec.tsdisplays specific kubernetes plans for GPU » Should render divided tables when GPU divider enabled

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/kubernetes/smoke-lke-create.spec.ts,cypress/e2e/core/linodes/plan-selection.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants