Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate password with special characters #1938

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

ferruhcihan
Copy link
Contributor

@ferruhcihan ferruhcihan commented Feb 12, 2025

Description

This PR fixes the issue of generating passwords with special characters.
apl-api => https://github.com/linode/apl-api/pull/632

Docs/Example

https://github.com/brendanashworth/generate-password/blob/master/example.js#L17

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

Copy link

github-actions bot commented Feb 12, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
47.44% (+0.11% 🔼)
900/1897
🔴 Branches
27.87% (+0.49% 🔼)
170/610
🔴 Functions
39.51% (+0.41% 🔼)
96/243
🔴 Lines
46.53% (+0.12% 🔼)
785/1687

Test suite run success

63 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 31f2bc0

@ferruhcihan ferruhcihan merged commit f16ce6b into main Feb 17, 2025
8 checks passed
@ferruhcihan ferruhcihan deleted the fc-fix-special-password branch February 17, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants