[server][controller][dvc][changelog] Avoid constructing D2Client for server, controller and clients. #1779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Previously, each component (server, controller, change_capture_client) constructed its own
D2Client
instance usingD2Builder
and passed in the necessary configurations. As theD2Client
continues to evolve, it now requires additional configuration parameters, some of which are unnecessary or unavailable in test and open-source environments. To address this, we refactor the components to accept pre-constructedD2Client
instances instead of constructing them internally.This change allows the deployable layer to construct fully customized
D2Client
s suited to the environment and usage, improving flexibility and testability.Affected Components:
Solution
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?