Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VelloDiagnosticsPlugin #118

Closed
wants to merge 4 commits into from
Closed

feat: add VelloDiagnosticsPlugin #118

wants to merge 4 commits into from

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Feb 16, 2025

PR adds a new VelloDiagnosticsPlugin which tracks the number of SVG, Text, Lottie, and Scene assets being rendered each frame.

To do this, backend implementation was modified:

  • Extracting now optimizes away assets not intersecting with a camera's render layers. (previously done in Render; this had to be moved to Extract since Extract is the only schedule with both access to the main and render world, where we synchronize back the frame data. This should be an improvement)
  • Rendering now occurs in 2 steps: Sorting assets, then Rendering.

As well, a new example has been added, which shows a diagnostic:
image

@DJMcNab DJMcNab removed their request for review February 17, 2025 10:01
Copy link
Collaborator

@RobertBrewitz RobertBrewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extract and render changes are nice, shame to hide in a feature PR, worth splitting into a separate PR for tracking/change log purposes?

bevy_diagnostics is included in bevy_render which is a dependency of bevy_text and bevy_ui in this project; But, is there a case for putting VelloDiagnosticsPlugin and the scene counting behind a feature flag?

@simbleau
Copy link
Member Author

The extract and render changes are nice, shame to hide in a feature PR, worth splitting into a separate PR for tracking/change log purposes?

bevy_diagnostics is included in bevy_render which is a dependency of bevy_text and bevy_ui in this project; But, is there a case for putting VelloDiagnosticsPlugin and the scene counting behind a feature flag?

I'd be open to a PR to feature-gate the diagnostics plugin, but currently not interested in taking up that work.

I will split this up into 2 PRs though, just found a way that makes sense.

@simbleau simbleau closed this Feb 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2025
…119)

Refactors the render phase internally by culling render items

Same as #118  except doesnt yet add the `VelloDiagnosticsPlugin`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants