Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send RST_STREAM when UnprocessedRequestException is raised #6157

Merged
merged 5 commits into from
Mar 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,22 @@ private void onWrapperCompleted(HttpResponseWrapper resWrapper, int id, @Nullabl
resWrapper.onSubscriptionCancelled(cause);

if (cause != null) {
if (cause instanceof UnprocessedRequestException ||
cause instanceof ClosedStreamException) {
return;
}
final int streamId = idToStreamId(id);
final Http2Stream stream = conn.stream(streamId);
if (stream == null || !stream.isHeadersSent()) {
return;
}
// Removing the response and decrementing `unfinishedResponses` isn't done immediately
// here. Instead, we rely on `Http2ResponseDecoder#onStreamClosed` to decrement
// `unfinishedResponses` after Netty decrements `numActiveStreams` in `DefaultHttp2Connection`
// so that `unfinishedResponses` is never greater than `numActiveStreams`.

// Reset the stream.
final int streamId = idToStreamId(id);

final int lastStreamId = conn.local().lastStreamKnownByPeer();
if (lastStreamId < 0 || // Did not receive a GOAWAY yet or
streamId <= lastStreamId) { // received a GOAWAY and the request's streamId <= lastStreamId
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* Copyright 2025 LINE Corporation
*
* LINE Corporation licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package com.linecorp.armeria.client;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

import java.time.Duration;
import java.util.concurrent.CompletableFuture;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import com.google.common.base.Strings;

import com.linecorp.armeria.common.AggregatedHttpResponse;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpResponse;
import com.linecorp.armeria.common.HttpStatus;
import com.linecorp.armeria.common.RequestHeaders;
import com.linecorp.armeria.server.ServerBuilder;
import com.linecorp.armeria.testing.junit5.server.ServerExtension;

import io.netty.handler.codec.http2.Http2Exception.HeaderListSizeException;

class HeaderListSizeExceptionTest {

@RegisterExtension
static ServerExtension server = new ServerExtension() {
@Override
protected void configure(ServerBuilder sb) {
sb.service("/", (ctx, req) -> HttpResponse.delayed(
() -> HttpResponse.of("OK"), Duration.ofMillis(100)));
}
};

@Test
void doNotSendRstStreamWhenHeaderListSizeExceptionIsRaised() throws InterruptedException {
final CompletableFuture<AggregatedHttpResponse> future = server.webClient().get("/").aggregate();
final String a = Strings.repeat("aa", 10000);
final RequestHeaders headers = RequestHeaders.of(HttpMethod.GET, "/", "foo", "bar",
"baz", a);
assertThatThrownBy(() -> server.webClient().execute(headers).aggregate().join())
.hasCauseInstanceOf(UnprocessedRequestException.class)
.cause()
.hasCauseInstanceOf(HeaderListSizeException.class);
// If the client sends RST_STREAM with invalid stream ID, the server will send GOAWAY back thus
// the first request will be failed with ClosedSessionException.
assertThat(future.join().status()).isSameAs(HttpStatus.OK);
}
}
Loading