Fetch all resources before watching them individually in KubernetesEndpointGroup
#6154
+276
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndpointGroup` Motivation: If `whenReady()` in `KubernetesEndpointGroup` completes with partial endpoints, the nodes could receive heavy loads. To prevent this , it would be better to fetch all resources using `GET` methods at the beginning instead of watching, and then use `WATCh` incrementally to update the information. Modifications: - Add `start()` method to initialize the resources at the beginning. - Remove the debounce logic which is no longer necessary. - Add `failInit()` in `DyanmicEndpointGroup` to notify an initialization failure. - Breaking) `KubernetesEndpointGroup` now requires `get` verbs in the RBAC rules to fetch endpoints. Result: `KubernetesEndpointGroup.whenReady()` now completes after collecting all endpoints.
🔍 Build Scan® (commit: fce9903) |
minwoox
approved these changes
Mar 11, 2025
| @@ -251,8 +239,54 @@ public static KubernetesEndpointGroupBuilder builder(Config kubeConfig) { | |||
| this.portName = portName; | |||
| this.nodeAddressFilter = nodeAddressFilter; | |||
| this.autoClose = autoClose; | |||
| watchJob(this::watchNode); | |||
| watchJob(this::start); | |||
There was a problem hiding this comment.
Rename to safeRun?
Suggested change
| watchJob(this::start); | |
| safeRun(this::start); |
There was a problem hiding this comment.
safeRun sounds like the job is executed in the current thread. Let me rename it to executeJob.
|
Please also fix the test failure. 😉 |
minwoox
reviewed
Mar 13, 2025
| newServiceWatch.close(); | ||
| return; | ||
| initial = false; | ||
| // Repeat until all `start()` requests are handled. |
There was a problem hiding this comment.
Can't it just to this only once when start() method is called concurrently? I'm not sure why it needs to handle all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If
whenReady()inKubernetesEndpointGroupis complete with partial endpoints, the nodes could receive heavy loads unexpectedly. To prevent this, it would be better to fetch all resources usingGETmethods at the beginning instead of watching, and then useWATCHincrementally to update the information.Modifications:
start()method to initialize the resources at the beginning.failInit()inDynamicEndpointGroupto notify an initialization failure.KubernetesEndpointGroupnow requiresgetverbs in the RBAC rules to fetch endpoints.Result:
KubernetesEndpointGroup.whenReady()is now complete after collecting all endpoints.