-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose experimental settings for dns #6127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
commented
Feb 26, 2025
core/src/main/java/com/linecorp/armeria/client/AbstractDnsResolverBuilder.java
Outdated
Show resolved
Hide resolved
jrhee17
commented
Feb 26, 2025
core/src/main/java/com/linecorp/armeria/client/AbstractDnsResolverBuilder.java
Outdated
Show resolved
Hide resolved
minwoox
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍 👍 👍
ikhoon
approved these changes
Mar 4, 2025
👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We received a report where it seemed like DNS nameservers do not correctly reflect changes in
/etc/resolv.conf
.The following issue has been pointed out to be a likely culprit:
netty/netty#14364
Given that we don't release as often recently and the cause isn't very clear, I propose that we expose methods that might solve the issue.
servicetalk
seems to have also applied a similar fix recently: https://github.com/apple/servicetalk/pull/3073/files.Modifications:
datagramChannelStrategy
which provides an option to create a channel per-resolutionsocketChannelType
so that users may use tcp-fallback in case resolution via udp doesn't work as expectedDnsEndpointGroup
functionality.Result:
DnsNameResolverBuilder
orDnsNameResolverBuilder#datagramChannelStrategy
#6122datagramChannelStrategy
which provides an option to create a channel per-resolution for DNS.