Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose experimental settings for dns #6127

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Feb 26, 2025

Motivation:

We received a report where it seemed like DNS nameservers do not correctly reflect changes in /etc/resolv.conf.
The following issue has been pointed out to be a likely culprit:
netty/netty#14364

Given that we don't release as often recently and the cause isn't very clear, I propose that we expose methods that might solve the issue.
servicetalk seems to have also applied a similar fix recently: https://github.com/apple/servicetalk/pull/3073/files.

Modifications:

  • Expose datagramChannelStrategy which provides an option to create a channel per-resolution
  • Expose socketChannelType so that users may use tcp-fallback in case resolution via udp doesn't work as expected
  • Given that it is difficult to test these settings, added a basic regression test to ensure that applying the settings doesn't interfere with based DnsEndpointGroup functionality.

Result:

@jrhee17 jrhee17 added this to the 1.32.0 milestone Feb 26, 2025
@jrhee17 jrhee17 marked this pull request as ready for review February 26, 2025 04:38
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 👍 👍

@minwoox minwoox merged commit 17611df into line:main Mar 4, 2025
14 checks passed
@minwoox
Copy link
Contributor

minwoox commented Mar 4, 2025

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider exposing DnsNameResolverBuilder or DnsNameResolverBuilder#datagramChannelStrategy
3 participants