Use DEBUG to log invalid authorization header in OAuth2TokenExtractor
#5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor` Motivation: Invalid authorization is a client error so it isn't much a server maintainer can do. It seems better to use `DEBUG` to detect problems during development. `WARN` could be noisy because it may be related to a monitoring system. Modifications: - Use `DEBUG` to log an invalid authorization header. Result: An invalid authorization header is now logged at `DEBUG` by the OAuth2 token extractor.
ikhoon
changed the title
DEBUG to log invalid authorization header in `OAuth2TokenExtr…DEBUG to log invalid authorization header in OAuth2TokenExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Invalid authorization is a client error so there isn't much a server maintainer can do. It seems better to use
DEBUGto detect problems during development.WARNcould be noisy because it may be related to a monitoring system.Modifications:
DEBUGto log an invalid authorization header.Result:
An invalid authorization header is now logged at
DEBUGby the OAuth2 token extractor.