Fix: resize GuestOS disk #3437
Draft
Fix: resize GuestOS disk #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
AkihiroSuda
reviewed
Apr 17, 2025
pkg/store/instance.go
Outdated
| func (inst *Instance) ResizeGuestOSDisk() error { | ||
| fName := filepath.Join(inst.Dir, filenames.DiffDisk) | ||
|
|
||
| cmd := exec.Command("limactl", "disk", "add", inst.Name, "--filename", fName) |
There was a problem hiding this comment.
limactl shouldn't invoke limactl itself unless it is inevitable or there is a significant benefit
songponssw
force-pushed
the
feat-edit-disk
branch
2 times, most recently
from
b3f95e5 to
a0800cf
Compare
7 tasks
songponssw
force-pushed
the
feat-edit-disk
branch
from
a0800cf to
baaa08f
Compare
songponssw
force-pushed
the
feat-edit-disk
branch
from
baaa08f to
e794dd0
Compare
Signed-off-by: Songpon Srisawai <songpon.ssw@gmail.com>
|
This implementation works fine for increasing the disk size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix: #1448
How Lima edit disk
limactl editupdates the disk value to the store. It does not resize disk image. Users have to manually resize byqemu-imgWhat I did
limactl disk addcommand to add an existing qcow2 disk to Lima.diffdiskof the instance to Lima, resize, and delete.