release: create branch for v0.18.5-beta.rc1 #9460

guggero · 2025-01-30T07:52:27Z

Preparation PR to kick off the v0.18.5-beta.rc1 release.

This PR includes rebased versions of the following PRs (in order):

If a node contains a channel, but doesn't have a corresponding edge in the graph database, updating the channel policy would fail. In this commit the edge is recreated if the channel exists. This ensures a node can recover from a missing edge in the graph database by calling updatechanpolicy.

This is a robustness option to ensure LND doesn't crash when this function is accidentally called with `AddChannelEdge(edge, nil)`.

This reverts commit 67419a7.

To make this itest work reliably with multiple parallel SQL transactions, we need to count both the settle and final HTLC events. Otherwise, sometimes the final events from earlier forwards are counted before the forward events from later forwards, causing a miscount of the settle events. If we expect both the settle and final event for each forward, we don't miscount.

We make sure that HTLCs which have already been decided upon are resolved before before allowing the external interceptor to potentially cancel them back. This makes the implementation for the external HTLC interceptor more streamlined.

We introduce a new specific fail resolution error when the external HTLC interceptor denies the incoming HTLC. Moreover we introduce a new traffic shaper method which moves the implementation of asset HTLC to the external layers. Moreover itests are adopted to reflect this new change.

The invoiceregistry test suite also includes unit tests for multi part payment especially also including payments to AMP invoices.

We always fetch the HTLCs for the specific setID, so there is no need to keep this code. In earlier versions we would call the UpdateInvoice method with `nil` for the setID therefore we had to lookup the AMPState. However this was error prune because in case one partial payment times-out the AMPState would change to cancelled and that could lead to not resolve HTLCs.

We need to make sure if we cancel an AMP invoice we also cancel all remaining HTLCs back.

coderabbitai · 2025-01-30T07:52:34Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-30T07:52:40Z

Pull reviewers stats

Stats of the last 30 days for lnd:

User	Total reviews	Time to review	Total comments
guggero 🥇	8 ▀▀	6h 3m	7 ▀
ellemouton 🥈	7 ▀▀	3d 16h 19m ▀▀	8 ▀
ziggie1984 🥉	6 ▀▀	7h 14m	18 ▀▀▀
yyforyongyu	4 ▀	6h 31m	3 ▀
bhandras	2 ▀	45m	0
bitromortac	2 ▀	1d 25m	4 ▀
saubyk	2 ▀	13h 37m	1
alexbosworth	1	4h	1
Roasbeef	1	1d 8h 55m ▀	7 ▀
morehouse	1	2d 2h 14m ▀	2
GeorgeTsagk	1	2d 8h 44m ▀	6 ▀
Abdulkbk	1	2d 21h 10m ▀	0
GustavoStingelin	1	8d 17h 37m ▀▀▀▀	1

guggero · 2025-01-30T08:38:03Z

Unit test failures are due to a mismatch in the fuzz corpora. We pull the files for master but this release branch doesn't have the latest corresponding changes in the fuzz tests.
And the integration test failures are due to found active channels, please close them properly, so a cleanup issue which can be ignored as well.

starius · 2025-01-30T13:41:09Z

Is #9226 a good candidate to be included into this release? It is a small lncli only patch, fixing miscalculation of the amount to be sent. Got into it several times after started using coin selection (--utxo flag) added recently.

starius · 2025-01-30T13:49:05Z

I propose to update Go used to build this release to the latest bugfix release (Go 1.22.11). Currently Go 1.22.6 is used.

This commit fixes the display of the amount when selecting utxos for the sendcoins command and combining it with the `-sweepall` flag. Prior this would show the full balance of the wallet. Now it shows the total amount of the selected utxos.

guggero · 2025-01-30T15:41:31Z

Added #9226.

This commit fixes a couple of issues that only occur on the branch we use for minor releases. The branch doesn't contain all refactors and cleanups so a couple of very minor things need to be fixed. Because we don't have all new features of the master branch we also can't apply the fuzz corpora for the master branch as that can lead to false positives.

guggero · 2025-01-30T16:27:40Z

Added #9462.

guggero · 2025-01-30T18:59:03Z

Added #9411 to get itests working.

Roasbeef

LGTM 🐋

Roasbeef · 2025-01-31T19:14:55Z

docs/release-notes/release-notes-0.18.5.md

+    - [Tooling and Documentation](#tooling-and-documentation)
+
+# Bug Fixes
+


Missing a release notes entry here: https://github.com/lightningnetwork/lnd/pull/9459/files#diff-7729387e95c78c2453c35bb8cf6dfe9afe197e34d0966f9fa07033ce22f9985aR22-R24

ziggie1984 · 2025-01-31T21:38:31Z

For RC2 we should also include: #9383

JssDWt and others added 30 commits January 28, 2025 17:56

lnrpc: add create_missing_edge flag

61a5bbb

lncli: add create_missing_edge

9609aa3

localchans: add test for createEdge and manager

454e94f

localchans: add policy when missing

b45deab

channeldb: skip nil scheduler options

ac0d295

This is a robustness option to ensure LND doesn't crash when this function is accidentally called with `AddChannelEdge(edge, nil)`.

docs: update release notes

ebd570b

localchans: do error if an edge policy is missing

f490212

Merge branch '0-18-5-branch-rc1-8805' into 0-18-5-branch-rc1

4ee2c20

go.mod: update btcwallet to latest to eliminate waddrmgr deadlock

3489a3b

go.mod: use local kvdb to reapply removal of global postgres lock

db71709

Reapply "kvdb/postgres: remove global application level lock"

52bfb14

This reverts commit 67419a7.

log: add sub-logger for kvdb/sqlbase

93c792c

batch: handle serialization errors correctly

e0cff36

graph/db: handle previously-unhandled errors

008dc65

sqldb: improve serialization error handling

2c03469

Makefile: tune params for db-instance for postgres itests

de283a6

Makefile: log to file instead of console

150672d

github workflow: save postgres log to zip file

29b683d

docs: update release-notes for 0.18.5

8b9885c

Merge branch '0-18-5-branch-rc1-9242' into 0-18-5-branch-rc1

be5238e

invoices: treat replayed HTLCs beforehand.

768882d

We make sure that HTLCs which have already been decided upon are resolved before before allowing the external interceptor to potentially cancel them back. This makes the implementation for the external HTLC interceptor more streamlined.

invoices: enhance the unit test suite.

728f8fc

The invoiceregistry test suite also includes unit tests for multi part payment especially also including payments to AMP invoices.

invoicerpc: add clarifying comment.

3c354cc

invoices: make sure the db uses the same testTime.

4b2793a

invoices: fix log entries and add a TODO.

bfbb73f

We need to make sure if we cancel an AMP invoice we also cancel all remaining HTLCs back.

docs: add release-notes.

7798231

guggero added 2 commits January 30, 2025 08:39

Merge branch '0-18-5-branch-rc1-9454' into 0-18-5-branch-rc1

063a903

build: bump version to v0.18.5-beta.rc1

e25f8fc

guggero added golang/build system Related to the go language and compiler releases no-changelog labels Jan 30, 2025

guggero added this to the v0.18.5 milestone Jan 30, 2025

guggero self-assigned this Jan 30, 2025

sputn1ck and others added 2 commits January 30, 2025 16:40

cmd/sendcoins: fix amt if select utxo

4836f7c

This commit fixes the display of the amount when selecting utxos for the sendcoins command and combining it with the `-sweepall` flag. Prior this would show the full balance of the wallet. Now it shows the total amount of the selected utxos.

Merge branch '0-18-5-branch-rc1-9226' into 0-18-5-branch-rc1

3909cd9

guggero added 4 commits January 30, 2025 17:22

multi: bump Go version to v1.22.11

bfcf76c

docs: add release notes

ffd84be

Merge branch '0-18-5-branch-rc1-9462' into 0-18-5-branch-rc1

dd261b8

guggero requested a review from Roasbeef January 30, 2025 16:28

ellemouton and others added 2 commits January 30, 2025 19:57

.github: bump upload-artifact action to v4

2e16ede

Merge branch '0-18-5-branch-rc1-9411' into 0-18-5-branch-rc1

8deab09

Roasbeef approved these changes Jan 31, 2025

View reviewed changes

docs/release-notes: add entry for AMP HTLC bug fix

871061e

Roasbeef merged commit 288f0e1 into 0-18-5-branch Jan 31, 2025
24 of 27 checks passed

guggero deleted the 0-18-5-branch-rc1 branch January 31, 2025 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: create branch for v0.18.5-beta.rc1 #9460

release: create branch for v0.18.5-beta.rc1 #9460

guggero commented Jan 30, 2025 •

edited

Loading

coderabbitai bot commented Jan 30, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jan 30, 2025

guggero commented Jan 30, 2025

starius commented Jan 30, 2025

starius commented Jan 30, 2025

guggero commented Jan 30, 2025

guggero commented Jan 30, 2025

guggero commented Jan 30, 2025

Roasbeef left a comment

Roasbeef Jan 31, 2025

ziggie1984 commented Jan 31, 2025

		- [Tooling and Documentation](#tooling-and-documentation)

		# Bug Fixes

release: create branch for v0.18.5-beta.rc1 #9460

release: create branch for v0.18.5-beta.rc1 #9460

Conversation

guggero commented Jan 30, 2025 • edited Loading

coderabbitai bot commented Jan 30, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jan 30, 2025

Pull reviewers stats

guggero commented Jan 30, 2025

starius commented Jan 30, 2025

starius commented Jan 30, 2025

guggero commented Jan 30, 2025

guggero commented Jan 30, 2025

guggero commented Jan 30, 2025

Roasbeef left a comment

Choose a reason for hiding this comment

Roasbeef Jan 31, 2025

Choose a reason for hiding this comment

ziggie1984 commented Jan 31, 2025

guggero commented Jan 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)