Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: exclude non-project files from go version consistency lint check #776

Closed
wants to merge 1 commit into from

Conversation

dstadulis
Copy link
Contributor

@dstadulis dstadulis commented Jan 30, 2024

Replaces #775
@ffranr noticed lint check (Go versions consistency check) was examining the local vendor directory.
This directory contains irrelevant project dependency files, which shouldn't be linted.
PR adds exclusion filters to remove directories from being linted.

@dstadulis
Copy link
Contributor Author

Testing:

$ exclusionDirectories=("./vendor" "adfl")
# Create `find` parameters to exclude directories
findExclusion=( "${exclusionDirectories[@]/#/"-not -path" }" )
echo $findExclusion
-not -path ./vendor -not -path adfl

$ find . -type f $findExclusion -name "*.Dockerfile" -o -name "Dockerfile"
./tools/Dockerfile
./taprpc/Dockerfile
./Dockerfile
./itest/loadtest/Dockerfile
./dev.Dockerfile
./make/builder.Dockerfile

@dstadulis dstadulis requested a review from guggero January 30, 2024 18:09
@dstadulis dstadulis self-assigned this Jan 30, 2024
@ffranr
Copy link
Contributor

ffranr commented Jan 30, 2024

Why does this PR replace #775

@dstadulis
Copy link
Contributor Author

Why does [#776] PR replace #775

Addresses guggero request to exclude with find

@dstadulis dstadulis requested a review from ffranr January 30, 2024 20:11
@ffranr
Copy link
Contributor

ffranr commented Jan 30, 2024

@dstadulis I've revised #775 , which also includes changes to the yaml linter that we need. I've requested your review there.

@dstadulis
Copy link
Contributor Author

Closing and continuing commentary in #755

@dstadulis dstadulis closed this Feb 5, 2024
@guggero guggero deleted the exclude-directories-dockerfiles branch March 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants