Comparing changes
Open a pull request
- 10 commits
- 16 files changed
- 1 contributor
Commits on Feb 26, 2025
-
tapfreighter+tapsend: don't use FundingDescriptor
We don't need the full funding descriptor, so this refactor makes it easier to use ValidateInputs and AssetFromTapCommitment in other situations.
-
-
multi: refactor funding packet creation into functions
As a preparation for a larger refactor on how we create virtual packets and distribute the coins selected for funding a transfer, we turn previous methods into functions. This will allow us to move those functions and easier unit test them.
-
tapfreighter: move funding related code into its own file
This is a pure code move. We're going to add unit tests for the moved functions in the next commit.
-
key_ring+tapgarden: remove DeriveKey from iface, improve mock
The DeriveKey method is currently not used anywhere. To simplify the mock, we simply remove it.
-
-
-
-
-
tapfreighter: create anchor output keys correctly
Once we have multiple asset IDs (and with that multiple distinct virtual packets), we need to make sure that we create our anchor outputs correctly. We need to make sure that the anchor outputs for the same index are actually the same (e.g. same internal key). If we just blindly loop over them and assign new keys, then two virtual outputs that reference the same anchor output index would have different keys and we'd fail a check then attempting to commit those packets to a BTC anchor transaction.
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c28aacfbc3f0849b6e20460e4fd3825425725a0f...f2b9b0f52a7d1f134b69ad136dc9d70f633bfe95