bLIP-57: Channel Lease Extensions (LSPS7) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzdidi
suggested changes
Jan 12, 2025
| ```json | ||
| { | ||
| "short_channel_id": "871428x964x0", | ||
| "channel_extension_expiry_blocks": 144, |
There was a problem hiding this comment.
Does it make sense to use new_channel_expiry_blocks here instead of channel_extension_expiry_blocks ?
There was a problem hiding this comment.
Good question. Either could work. Open to hear arguments in favor of one over the other.
There was a problem hiding this comment.
Just re-read LSPs1 and now I am convinced it is better to keep channel_extension_expiry_blocks for the sake of uniformity.
|
We have our service deployed to Mutinynet and testnet3, if anyone would like to poke at it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.