Skip to content

Commit

Permalink
we use java 8, removed old setting, increased memory
Browse files Browse the repository at this point in the history
  • Loading branch information
@fmpwizard
fmpwizard committed Jun 15, 2017
1 parent 907807d commit aeeac27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion liftsh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if test -f ~/.liftsh.config; then
fi

# Internal options, always specified
INTERNAL_OPTS="-Dfile.encoding=UTF-8 -Xmx1768m -noverify -XX:ReservedCodeCacheSize=296m -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:MaxPermSize=812m"
INTERNAL_OPTS="-Dfile.encoding=UTF-8 -Xmx3768m -noverify -XX:ReservedCodeCacheSize=296m -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC"

# Add 64bit specific option
exec java -version 2>&1 | grep -q "64-Bit" && INTERNAL_OPTS="${INTERNAL_OPTS} -XX:+UseCompressedOops -XX:ReservedCodeCacheSize=328m"
Expand Down

3 comments on commit aeeac27

@farmdawgnation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey did this change make it back into master?

@fmpwizard
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to send the PR for it. we don't really have to increase the memory, but removing XX:MaxPermSize does make sense now that we use java 8

@farmdawgnation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

I'm curious though: how valuable is liftsh at this point? Is there significant value we're adding by encouraging folks to use something other than their system sbt? I, for one, never use it.

(There's probably a longer topic here that belongs on the ML, but trying to get your thoughts on it while you're here.)

Please sign in to comment.