Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/css): custom-control-outside shouldn't be clickable beyon… #5954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Feb 27, 2025

…d the text

https://liferay.atlassian.net/browse/LPD-50093

I wanted to remove custom-control-outside from our checkboxes, but there might be users targeting it with a CSS selector. What do you think?

Copy link
Member

@SelenaAungst SelenaAungst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still having trouble with testing stuff on the new Clay site, but the code looks good to me.

@matuzalemsteles
Copy link
Member

I wanted to remove custom-control-outside from our checkboxes, but there might be users targeting it with a CSS selector. What do you think?

I agree, the ideal would be to just remove it in a next major version, you can note this in the package's BREAKING.md so we don't forget to remove it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants