Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-29322 - Improve L0 accessible colors to be closer to 3:1 ratio #5837

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

marcoscv-work
Copy link
Member

@marcoscv-work marcoscv-work commented Jun 23, 2024

Related to this Lexicon PR:
liferay-design/liferay.design#1228

image

@marcoscv-work marcoscv-work requested a review from pat270 June 24, 2024 15:22
Copy link
Member

@pat270 pat270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoscv-work we need to update the colors in Cadmin also

@marcoscv-work
Copy link
Member Author

@marcoscv-work we need to update the colors in Cadmin also

thanks! I will add those variables!

@marcoscv-work marcoscv-work force-pushed the L0-colorChange branch 2 times, most recently from e98368e to dd0dcb8 Compare July 4, 2024 07:10
@marcoscv-work marcoscv-work requested a review from pat270 July 4, 2024 07:54
@marcoscv-work
Copy link
Member Author

@pat270 I've already added variables! thanks!

@pat270
Copy link
Member

pat270 commented Jul 8, 2024

@marcoscv-work I decided it's better to use Sass color functions to derive the L0 colors just in case someone is relying on it. I think we can change the colors to hex in another ticket.

@pat270 pat270 merged commit 38afae6 into liferay:master Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants