fix(@clayui/picker): LPD-28522 Fix language selector not displaying correctly on web content #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heu @matuzalemsteles @pat270 @ethib137 |
ilzamcmed
force-pushed
the
LPD-28522
branch
2 times, most recently
from
82ee1a4 to
eefb5ae
Compare
ilzamcmed
force-pushed
the
LPD-28522
branch
3 times, most recently
from
05e517c to
5dcfe70
Compare
ethib137
reviewed
Jun 21, 2024
ethib137
reviewed
Jun 21, 2024
|
I sent a commit to simplify the implementation a little bit. |
|
Nice work on this @ilzamcmed and @matuzalemsteles . LGTM. I think we really need some tests for this to ensure the menu continues behaving as expected in all the examples we listed on this PR. I don't mind if we merge this first and create a separate task to add the tests. What do you guys think? Do tests seem helpful for this? |
|
I think we can leave the examples in the stories with menu open by default to do this as a chromatic test, the unit test is a little bad for reproducing this because normally the sizes are fake and it is not very reliable because this is normally a mock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://liferay.atlassian.net/browse/LPD-28522
Motivation
The language selector is not displaying correctly: the labels of the status are overlapping the language key and the number of fields is not appearing.
Proposed Solution
Be able to set an auto width so that the menu can grow with the content.
Screenshots
Commits