Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@clayui/popover): LPD-15615 Popover: focus is not redirected to popover when disableScroll prop is true #5833

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix(@clayui/popover): LPD-15615 Popover: focus is not redirected to popover when disableScroll prop is true #5833

merged 4 commits into from
Jun 19, 2024

Conversation

ilzamcmed
Copy link
Member

@ilzamcmed ilzamcmed commented Jun 14, 2024 •
edited
Loading

  • fix(@clayui/popover): LPD-15615 Add focus on popover when disableScroll is enabled
  • fix(@clayui/css): LPD-15615 Add focus style on popover when disableScroll is enabled

Jira issue: https://liferay.atlassian.net/browse/LPD-15615

@ilzamcmed
Copy link
Member Author

Hey @pat270 @matuzalemsteles
This PR is ready for review!
Thanks

matuzalemsteles
matuzalemsteles approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matuzalemsteles matuzalemsteles requested a review from pat270 June 17, 2024 23:31
@pat270
Copy link
Member

pat270 commented Jun 18, 2024

@ilzamcmed I removed border radius from the focus styles and added focus styles to Cadmin. I also removed the $focus variable from clay-popover-variant. Those are present in links to maintain backward compatibility with the 2.x Sass API. It was never existed in clay-popover-variant.

@ilzamcmed
Copy link
Member Author

Thanks, @pat270! 🎉

@matuzalemsteles matuzalemsteles merged commit 5cd63dd into liferay:master Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat270 pat270 pat270 approved these changes

@matuzalemsteles matuzalemsteles matuzalemsteles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilzamcmed @pat270 @matuzalemsteles