LPD-50244 Implementing skipped integration tests #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50244 1 Successful Jobs:For more details click here. |
smottal
requested changes
Feb 28, 2025
| @@ -108,13 +98,16 @@ public void testPostSpecificationListTypeDefinition() throws Exception { | |||
| _cpSpecificationOption.getCPSpecificationOptionId(), 0L)); | |||
| } | |||
|
|
|||
| protected String[] getAdditionalAssertFieldNames() { | |||
| @@ -125,12 +118,49 @@ public void testPostSpecificationListTypeDefinition() throws Exception { | |||
| return _cpSpecificationOption.getCPSpecificationOptionId(); | |||
| } | |||
|
|
|||
| protected ListTypeDefinition | |||
| Long id, ListTypeDefinition listTypeDefinition) | ||
| throws Exception { | ||
|
|
||
| return _addListTypeDefinition(randomListTypeDefinition()); |
There was a problem hiding this comment.
is it correct that here we generate another random and not use the parameter one?
| return _addListTypeDefinition(randomListTypeDefinition()); | ||
| } | ||
|
|
||
| protected Long testGetSpecificationIdListTypeDefinitionsPage_getId() |
| @@ -124,12 +107,30 @@ public void testDeleteProductConfigurationListAccountGroup() | |||
| Assert.assertEquals(0, page.getTotalCount()); | |||
| } | |||
|
|
|||
| @Ignore | |||
| @Override | |||
There was a problem hiding this comment.
question: what does wrong the "base" test that we need to override?
There was a problem hiding this comment.
this
@Test
public void testGraphQLDeleteProductConfigurationListAccountGroup()
throws Exception {
Assert.assertTrue(false);
}
|
Jenkins Build:test-portal-source-format#7795 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-commerce#5986 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - CrescenzoRegaLF > liferay-commerce - PR#5986 - 2025-02-28[07:26:59] Testray Build ID:Testray Importer:publish-testray-report#5541 |
❌ ci:test:stable - 23 out of 24 jobs passed❌ ci:test:relevant - 39 out of 44 jobs passed in 2 hours 9 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a ci:test:stable - 23 out of 24 jobs PASSED1 Failed Jobs:
23 Successful Jobs:ci:test:relevant - 39 out of 44 jobs PASSED5 Failed Jobs:
39 Successful Jobs:For more details click here.Failures unique to this pull:
Failures in common with acceptance upstream results at 55d1ceb: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#11929 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-commerce#5986 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - CrescenzoRegaLF > liferay-commerce - PR#5986 - 2025-02-28[09:43:24] Testray Build ID:Testray Importer:publish-testray-report#24596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-50244