Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-50195 Return Guest Account immediately. #5981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LPD-50195 Return Guest Account immediately. #5981

wants to merge 1 commit into from
+8 −0

Conversation

brianikim
Copy link

@brianikim brianikim commented Feb 28, 2025 •
edited
Loading

@smottal , @andrea-ale-sbarra

See https://liferay.atlassian.net/browse/LPD-50195.

Test already covered by https://github.com/liferay/liferay-portal/blob/a3eeae509ec5c5299f93d233cf94f3f2e7b64129/modules/apps/account/account-test/src/testIntegration/java/com/liferay/account/manager/test/CurrentAccountEntryManagerTest.java#L142

I believe the commit is best approach to solution since, if you are a GUEST user, none of the channelRel and channelAccountEntry checks will return anything.

I intentionally did not combine:

	if (accountEntry != null) {
			if (accountEntry.isGuestAccount()) {

into

	if (accountEntry != null && !accountEntry.isGuestAccount()) {

Because we need the accountEntry returned for the specific check.

Sincerely,
Brian I. Kim

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianikim
Copy link
Author

ci:test:sf

@brianikim
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a3eeae509ec5c5299f93d233cf94f3f2e7b64129

Sender Branch:

Branch Name: LPD-50195
Branch GIT ID: 63a33e32e637c16895dbc4fdb4fb8c0473e0eb5c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:153118094

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 23 out of 24 jobs passed

❌ ci:test:relevant - 42 out of 44 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a3eeae509ec5c5299f93d233cf94f3f2e7b64129

Upstream Comparison:

Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

ci:test:stable - 23 out of 24 jobs PASSED

1 Failed Jobs:

23 Successful Jobs:
    ci:test:relevant - 42 out of 44 jobs PASSED

    2 Failed Jobs:

    42 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      For upstream results, click here.

      @smottal
      Copy link
      Collaborator

      smottal commented Feb 28, 2025

      ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 32 out of 32 jobs passed in 1 hour 22 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 55d8c2f17994f074d988d0d80d66c6adc55a5949

      ci:test:stable - 32 out of 32 jobs PASSED
      32 Successful Jobs:
      For more details click here.

      @liferay-continuous-integration
      Copy link
      Collaborator

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @smottal smottal smottal approved these changes

      @liferay-commerce liferay-commerce Awaiting requested review from liferay-commerce liferay-commerce is a code owner

      Assignees
      No one assigned
      Labels
      ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      3 participants
      @brianikim @liferay-continuous-integration @smottal