LPD-48103 #5975

alessiorendina · 2025-02-27T15:08:00Z

https://liferay.atlassian.net/browse/LPD-48103

liferay-continuous-integration · 2025-02-27T15:08:06Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

alessiorendina · 2025-02-27T15:14:20Z

ci:test:sf

alessiorendina · 2025-02-27T15:15:46Z

ci:test:commerce-integration

liferay-continuous-integration · 2025-02-27T15:18:40Z

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29262a43f1f4cfa4de154c272af8d6dd732879c7

Sender Branch:

Branch Name: LPD-48103
Branch GIT ID: f09214a24f89946a74fd5d948f84fc76fab91fd3

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

format-source-files:
     [java] java.lang.Exception: Found 19 formatting issues:
     [java] 1: Incorrect commit message in SHA f09214a24f89946a74fd5d948f84fc76fab91fd3: Each breaking change should have one, and only one "# breaking", "## What", "## Why" and ## (Optional). Use "----" to split each breaking change.: ./modules/apps/commerce/commerce-product-api/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
     [java] 2: Test class "com.liferay.commerce.product.internal.upgrade.v5_28_0.test.CPDefinitionSpecificationOptionValueUpgradeProcessTest" does not exist: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPDefinitionSpecificationOptionValueUpgradeProcess.java (SourceCheck:JavaUpgradeMissingTestCheck)
     [java] 3: Test class "com.liferay.commerce.product.internal.upgrade.v5_28_0.test.CPSpecificationOptionUpgradeProcessTest" does not exist: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPSpecificationOptionUpgradeProcess.java (SourceCheck:JavaUpgradeMissingTestCheck)
     [java] 4: ./modules/apps/commerce/commerce-product-service/bnd.bnd expected:<...e-SchemaVersion: 5.2[8].0
     [java] Liferay-Service: ...> but was:<...e-SchemaVersion: 5.2[7].0
     [java] Liferay-Service: ...>
     [java] 5: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/CPSpecificationOptionModelSearchConfigurator.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[3] Liferay, Inc. https...>
     [java] 6: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/spi/model/index/contributor/CPSpecificationOptionModelDocumentContributor.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[4] Liferay, Inc. https...>
     [java] 7: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/spi/model/index/contributor/CPSpecificationOptionModelIndexerWriterContributor.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[4] Liferay, Inc. https...>

liferay-continuous-integration · 2025-02-27T15:20:35Z

Jenkins Build:test-portal-source-format#11913

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-commerce#5975

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - alessiorendina > liferay-commerce - PR#5975 - 2025-02-27[07:14:35]

Testray Build ID:152541306

Testray Importer:publish-testray-report#44491

alessiorendina · 2025-02-27T15:48:26Z

ci:test:sf

liferay-continuous-integration · 2025-02-27T15:55:14Z

❌ ci:test:sf - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29262a43f1f4cfa4de154c272af8d6dd732879c7

Sender Branch:

Branch Name: LPD-48103
Branch GIT ID: 49b312062f027f15210a48bf3dd71b80a25316e6

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

format-source-files:
     [java] java.lang.Exception: Found 18 formatting issues:
     [java] 1: Incorrect commit message in SHA 49b312062f027f15210a48bf3dd71b80a25316e6: 'modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPDefinitionSpecificationOptionValueService.java' points to nonexistent file. "## What" should be followed by only one path, which is from https://github.com/liferay/liferay-portal/blob/master/.: ./modules/apps/commerce/commerce-product-api/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
     [java] 2: Test class "com.liferay.commerce.product.internal.upgrade.v5_28_0.test.CPDefinitionSpecificationOptionValueUpgradeProcessTest" does not exist: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPDefinitionSpecificationOptionValueUpgradeProcess.java (SourceCheck:JavaUpgradeMissingTestCheck)
     [java] 3: Test class "com.liferay.commerce.product.internal.upgrade.v5_28_0.test.CPSpecificationOptionUpgradeProcessTest" does not exist: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPSpecificationOptionUpgradeProcess.java (SourceCheck:JavaUpgradeMissingTestCheck)
     [java] 4: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/CPSpecificationOptionModelSearchConfigurator.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[3] Liferay, Inc. https...>
     [java] 5: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/spi/model/index/contributor/CPSpecificationOptionModelDocumentContributor.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[4] Liferay, Inc. https...>
     [java] 6: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/search/spi/model/index/contributor/CPSpecificationOptionModelIndexerWriterContributor.java expected:<...pyrightText: (c) 202[5] Liferay, Inc. https...> but was:<...pyrightText: (c) 202[4] Liferay, Inc. https...>

liferay-continuous-integration · 2025-02-27T15:58:30Z

Jenkins Build:test-portal-source-format#7026

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-commerce#5975

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - alessiorendina > liferay-commerce - PR#5975 - 2025-02-27[07:48:41]

Testray Build ID:152573383

Testray Importer:publish-testray-report#27550

liferay-continuous-integration · 2025-02-27T17:32:03Z

❌ ci:test:commerce-integration - 1 out of 19 jobs passed in 2 hours 14 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29262a43f1f4cfa4de154c272af8d6dd732879c7

Upstream Comparison:

Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

ci:test:commerce-integration - 1 out of 19 jobs PASSED

18 Failed Jobs:

1 Successful Jobs:

For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 55d1ceb:

liferay-continuous-integration · 2025-02-27T17:34:43Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6287

Jenkins Report:jenkins-report.html

Jenkins Suite:commerce-integration

Pull Request:liferay-commerce#5975

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:commerce-integration - alessiorendina > liferay-commerce - PR#5975 - 2025-02-27[07:15:57]

Testray Build ID:152646642

Testray Importer:publish-testray-report#36596

gianmarcobrunialti · 2025-02-28T08:18:18Z

G2G code-wise, checked together offline too. Let's fix the formal remnants.

…ote service implementation

…nd remote service implementation

# breaking ## What modules/apps/commerce/commerce-product-content-api/src/main/java/com/liferay/commerce/product/content/helper/CPContentHelper.java modules/apps/commerce/commerce-product-content-api/src/main/java/com/liferay/commerce/product/content/helper/CPContentHelper.java hasCPDefinitionSpecificationOptionValues(long cpDefinitionId) method has been removed ## Why because internally it is calling getCPDefinitionSpecificationOptionValues(long cpDefinitionId) and check if it is not empty, so getCPDefinitionSpecificationOptionValues(long cpDefinitionId) can be just called directly to do the check instead of calling it 2 times for the same info ----

# breaking ## What modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPDefinitionSpecificationOptionValueService.java modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPDefinitionSpecificationOptionValueService.java now include visible boolean parameter into add and update methods ## Why because the table now includes this column to manage the specifications visibility on front store ---- ## What modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPSpecificationOptionService.java modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPSpecificationOptionService.java now include visible boolean parameter into add and update methods ## Why because the table now includes this column to manage the specifications visibility on front store ----

alessiorendina · 2025-02-28T08:38:54Z

ci:test:sf

liferay-continuous-integration · 2025-02-28T10:28:28Z

❌ ci:test:sf - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a3eeae509ec5c5299f93d233cf94f3f2e7b64129

Sender Branch:

Branch Name: LPD-48103
Branch GIT ID: 1ad02fd65f17e0668d721b62550eb4c27da2f462

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

format-source-files:
     [java] java.lang.Exception: Found 8 formatting issues:
     [java] 1: Incorrect commit message in SHA 1ad02fd65f17e0668d721b62550eb4c27da2f462: 'modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/service/CPDefinitionSpecificationOptionValueService.java' points to nonexistent file. "## What" should be followed by only one path, which is from https://github.com/liferay/liferay-portal/blob/master/.: ./modules/apps/commerce/commerce-product-api/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
     [java] 2: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPSpecificationOptionUpgradeProcess.java expected:<...opyrightText: (c) 20[25] Liferay, Inc. https...> but was:<...opyrightText: (c) 20[00] Liferay, Inc. https...>
     [java] 3: ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/upgrade/v5_28_0/CPDefinitionSpecificationOptionValueUpgradeProcess.java expected:<...opyrightText: (c) 20[25] Liferay, Inc. https...> but was:<...opyrightText: (c) 20[00] Liferay, Inc. https...>
     [java] 4: ./modules/apps/commerce/headless/headless-commerce/headless-commerce-admin-catalog-impl/src/main/java/com/liferay/headless/commerce/admin/catalog/internal/resource/v1_0/ProductConfigurationListResourceImpl.java expected:<...rtal.kernel.search.S[]ort;
     [java] import com.life...> but was:<...rtal.kernel.search.S[earchContext;
     [java] import com.liferay.portal.kernel.search.S]ort;
     [java] import com.life...>
     [java] 5: ./modules/apps/commerce/headless/headless-commerce/headless-commerce-admin-catalog-impl/src/main/java/com/liferay/headless/commerce/admin/catalog/internal/resource/v1_0/ProductConfigurationResourceImpl.java expected:<...rtal.kernel.search.S[]ort;
     [java] import com.life...> but was:<...rtal.kernel.search.S[earchContext;
     [java] import com.liferay.portal.kernel.search.S]ort;
     [java] import com.life...>
     [java] 6: Truncated message :
     [java] ./modules/apps/commerce/headless/headless-commerce/headless-commerce-admin-catalog-impl/src/main/java/com/liferay/headless/commerce/admin/catalog/internal/resource/v1_0/SkuResourceImpl.java expected:<...etra.function.Unsafe[Function;
     [java] import com.liferay.petra.string.StringPool;
     [java] import com.liferay.portal.configuration.module.configuration.ConfigurationProvider;

liferay-continuous-integration · 2025-02-28T12:23:48Z

Jenkins Build:test-portal-source-format#2775

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-commerce#5975

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - alessiorendina > liferay-commerce - PR#5975 - 2025-02-28[02:21:16]

Testray Build ID:153118369

Testray Importer:publish-testray-report#5303

alessiorendina requested a review from liferay-commerce as a code owner February 27, 2025 15:08

liferay-continuous-integration added ci:test:sf - pending ci:test:commerce-integration - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 27, 2025

alessiorendina force-pushed the LPD-48103 branch from f09214a to 49b3120 Compare February 27, 2025 15:47

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - failure ci:test:sf - pending labels Feb 27, 2025

liferay-continuous-integration added ci:test:commerce-integration - failure and removed ci:test:commerce-integration - pending labels Feb 27, 2025

alessiorendina added 7 commits February 28, 2025 09:32

LPD-48103 Added new column into service xml

fa916e9

LPD-48103 Added new upgrade processes

5187d33

LPD-48103 Added new constant

2a84194

LPD-48103 Refactor specification option indexer

ee5dda6

LPD-48103 Refactor product specification option service local and rem…

4d28b4d

…ote service implementation

LPD-48103 Refactor product specification option value service local a…

81cb916

…nd remote service implementation

LPD-48103 Update usages

cd0cdcf

alessiorendina added 11 commits February 28, 2025 09:35

LPD-48103 Fixed product specification fragment renderer

b1d1455

LPD-48103 Added new field to specification schemas

7f18c58

LPD-48103 Added new field to dto converters

885875b

LPD-48103 Fixed specification entity model

7f1f8cb

LPD-48103 Added new upgrade process integration tests

1acb683

LPD-48103 Added new functional tests

dd795fe

LPD-48103 SF

7c1c323

LPD-48103 Regen services

68fb790

LPD-48103 Regen REST module

5897d28

alessiorendina force-pushed the LPD-48103 branch from 49b3120 to 1ad02fd Compare February 28, 2025 08:38

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - failure ci:test:sf - pending labels Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPD-48103 #5975

LPD-48103 #5975

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

Base Branch:

Upstream Comparison:

18 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Feb 27, 2025

gianmarcobrunialti commented Feb 28, 2025

alessiorendina commented Feb 28, 2025

liferay-continuous-integration commented Feb 28, 2025

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 28, 2025

LPD-48103 #5975

Are you sure you want to change the base?

LPD-48103 #5975

Conversation

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 27, 2025

alessiorendina commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 7 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 27, 2025

liferay-continuous-integration commented Feb 27, 2025

❌ ci:test:commerce-integration - 1 out of 19 jobs passed in 2 hours 14 minutes

Base Branch:

Upstream Comparison:

18 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Feb 27, 2025

gianmarcobrunialti commented Feb 28, 2025

alessiorendina commented Feb 28, 2025

liferay-continuous-integration commented Feb 28, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 7 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 28, 2025