Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-40423 Search and Pagination for Order Items listing table are not working #5971

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

LPD-40423 Search and Pagination for Order Items listing table are not working #5971

wants to merge 5 commits into from

Conversation

monaco-fabio
Copy link

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@monaco-fabio
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26ff042a7230aca438731909c0ff739a4ecaa938

Sender Branch:

Branch Name: LPD-40423
Branch GIT ID: 70ef9cfc8513d60e8ef6ec198f4cc6629d372be5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@monaco-fabio
Copy link
Author

ci:test:relevant

@monaco-fabio
Copy link
Author

ci:test:commerce

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 24 out of 25 jobs passed

❌ ci:test:relevant - 43 out of 45 jobs passed in 1 hour 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26ff042a7230aca438731909c0ff739a4ecaa938

Upstream Comparison:

Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

ci:test:stable - 24 out of 25 jobs PASSED

1 Failed Jobs:

24 Successful Jobs:
    ci:test:relevant - 43 out of 45 jobs PASSED

    2 Failed Jobs:

    43 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. rest-builder/0/0
             [echo] index bb53048d24d27..29ce85f88a104 100644
     [echo] --- a/modules/apps/commerce/headless/headless-commerce/headless-commerce-delivery-cart-impl/src/main/java/com/liferay/headless/commerce/delivery/cart/internal/resource/v1_0/BaseCartItemResourceImpl.java
     [echo] +++ b/modules/apps/commerce/headless/headless-commerce/headless-commerce-delivery-cart-impl/src/main/java/com/liferay/headless/commerce/delivery/cart/internal/resource/v1_0/BaseCartItemResourceImpl.java
     [echo] @@ -672,11 +672,11 @@ public abstract class BaseCartItemResourceImpl
     [echo]        ),
     [echo]        @io.swagger.v3.oas.annotations.Parameter(
     [echo]          in = io.swagger.v3.oas.annotations.enums.ParameterIn.QUERY,
     [echo] -        name = "skuId"
     [echo] +        name = "search"
     [echo]        ),
     [echo]        @io.swagger.v3.oas.annotations.Parameter(
     [echo]          in = io.swagger.v3.oas.annotations.enums.ParameterIn.QUERY,
     [echo] -        name = "search"
     [echo] +        name = "skuId"
     [echo]        )
     [echo]      \}
     [echo]    )
     [echo] @@ -693,11 +693,11 @@ public abstract class BaseCartItemResourceImpl
     [echo]        @javax.ws.rs.PathParam("cartId")
     [echo]        Long cartId,
     [echo]        @io.swagger.v3.oas.annotations.Parameter(hidden = true)
     [echo] -      @javax.ws.rs.QueryParam("skuId")
     [echo] -      Long skuId,
     [echo] -      @io.swagger.v3.oas.annotations.Parameter(hidden = true)
     [echo]        @javax.ws.rs.QueryParam("search")
     [echo]        String search,
     [echo] +      @io.swagger.v3.oas.annotations.Parameter(hidden = true)
     [echo] +      @javax.ws.rs.QueryParam("skuId")
     [echo] +      Long skuId,
     [echo]        @javax.ws.rs.core.Context Pagination pagination)
     [echo]      throws Exception \{
     [echo]  
[stopwatch] [run.batch.test.action: 31:22.185 sec]
     [echo] .
     [echo] 
     [echo] Detected build REST changes. See above build REST log for more
     [echo] information. Make sure to commit in all build REST results.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1203081491.properties
        1. com.liferay.jenkins.JenkinsLogAsserterTest

      For upstream results, click here.

      @monaco-fabio
      Copy link
      Author

      ci:stop

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:commerce - 165 out of 230 jobs passed in 1 hour 43 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 26ff042a7230aca438731909c0ff739a4ecaa938

      Upstream Comparison:

      Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
      Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

      ci:test:commerce - 165 out of 230 jobs PASSED

      65 Failed Jobs:

      165 Successful Jobs:
        For more details click here.

        Failures unique to this pull:

        6. ...

        @liferay-continuous-integration
        Copy link
        Collaborator

        @monaco-fabio
        Copy link
        Author

        ci:test:sf

        @liferay-continuous-integration
        Copy link
        Collaborator

        ✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

        Click here for more details.

        Base Branch:

        Branch Name: master
        Branch GIT ID: 26ff042a7230aca438731909c0ff739a4ecaa938

        Sender Branch:

        Branch Name: LPD-40423
        Branch GIT ID: c037d52034361ef0e2f6f6e39003008690d370ee

        1 out of 1jobs PASSED
        1 Successful Jobs:
        For more details click here.

        @monaco-fabio
        Copy link
        Author

        ci:test:sf

        @liferay-continuous-integration
        Copy link
        Collaborator

        ✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

        Click here for more details.

        Base Branch:

        Branch Name: master
        Branch GIT ID: 6a7d135d819c60c44d60ef4f685a89f01ad539bd

        Sender Branch:

        Branch Name: LPD-40423
        Branch GIT ID: a4118bdc258a17f7f69a0b89235b72f79bc10a2f

        1 out of 1jobs PASSED
        1 Successful Jobs:
        For more details click here.

        @monaco-fabio
        Copy link
        Author

        ci:test:relevant

        @monaco-fabio
        Copy link
        Author

        ci:test:commerce

        @liferay-continuous-integration
        Copy link
        Collaborator

        @liferay-continuous-integration
        Copy link
        Collaborator

        ✔️ ci:test:stable - 25 out of 25 jobs passed

        ✔️ ci:test:relevant - 45 out of 45 jobs passed in 1 hour 28 minutes

        Click here for more details.

        Base Branch:

        Branch Name: master
        Branch GIT ID: 6a7d135d819c60c44d60ef4f685a89f01ad539bd

        Upstream Comparison:

        Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
        Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

        ci:test:stable - 25 out of 25 jobs PASSED
        25 Successful Jobs:
        ci:test:relevant - 45 out of 45 jobs PASSED
        45 Successful Jobs:
        For more details click here.

        @liferay-continuous-integration
        Copy link
        Collaborator

        @liferay-continuous-integration
        Copy link
        Collaborator

        ❌ ci:test:commerce - 192 out of 230 jobs passed in 2 hours 36 minutes

        Click here for more details.

        Base Branch:

        Branch Name: master
        Branch GIT ID: 6a7d135d819c60c44d60ef4f685a89f01ad539bd

        Upstream Comparison:

        Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
        Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

        ci:test:commerce - 192 out of 230 jobs PASSED

        38 Failed Jobs:

        192 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          6. ...

          @liferay-continuous-integration
          Copy link
          Collaborator

          @monaco-fabio
          Copy link
          Author

          ci:report:151704758

          @liferay-continuous-integration
          Copy link
          Collaborator

          Build completed.

          Testray CSV has been generated successfully for testrayBuildID: 151704758.

          Job Link: generate-testray-csv

          Testray CSV Link: testray-results-151704758.csv

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers

          @liferay-commerce liferay-commerce Awaiting requested review from liferay-commerce liferay-commerce is a code owner

          Assignees
          No one assigned
          Labels
          ci:test - success ci:test:commerce - failure ci:test:relevant - success ci:test:sf - success ci:test:stable - success
          Projects
          None yet
          Milestone
          No milestone
          Development

          Successfully merging this pull request may close these issues.
          2 participants
          @monaco-fabio @liferay-continuous-integration