LPD-49326 commerce part of LPD-47718 #5953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-47925-LPD-49326-commerce 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#7521 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build ID:Testray Importer:publish-testray-report#28659 |
|
ci:test:um |
liferay-continuous-integration
added
ci:test:um - pending
ci:test:um - failure
and removed
ci:test:um - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#11057 Jenkins Report:jenkins-report.html Jenkins Suite:um Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build ID:Testray Importer:publish-testray-report#24456 |
|
For reference, this PR may need this fix -> liferay-frontend#4759 |
izaera
force-pushed
the
LPD-47925-LPD-49326-commerce
branch
from
4b536d7 to
21a4f14
Compare
|
I've fixed the rebase conflicts |
|
ci:test:sf |
|
ci:test:relevant |
|
Still waiting for liferay-frontend#4759 so I won't run |
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-47925-LPD-49326-commerce 1 Failed Jobs:For more details click here. [exec] > Task :packageRunCheckFormat
[exec] yarn run v1.13.0
[exec] \$ node-scripts check:ci
[exec]
[exec] ⚙️ Running preflight checks...
[exec]
[exec] ⚙️ Checking outdated tsconfig.json files ...
[exec]
[exec] ⚙️ Running TypeScript checks on modified files...
[exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
[exec] ❌ Checked apps/commerce/commerce-frontend-js
[exec] ../../frontend-js/frontend-js-components-web/src/main/resources/META-INF/resources/feature_indicator/FeatureIndicator.tsx(9,22): error TS2614: Module '"@clayui/popover"' has no exported member 'ALIGN_POSITIONS'. Did you mean to use 'import ALIGN_POSITIONS from "@clayui/popover"' instead?
[exec] ../../frontend-js/frontend-js-components-web/src/main/resources/META-INF/resources/translation_manager/TranslationAdminStatusLabel.tsx(6,9): error TS2614: Module '"@clayui/alert"' has no exported member 'DisplayType'. Did you mean to use 'import DisplayType from "@clayui/alert"' instead?
[exec]
[exec] ❌ Checked apps/account/account-admin-web
[exec] ../../frontend-js/frontend-js-components-web/src/main/resources/META-INF/resources/feature_indicator/FeatureIndicator.tsx(9,22): error TS2614: Module '"@clayui/popover"' has no exported member 'ALIGN_POSITIONS'. Did you mean to use 'import ALIGN_POSITIONS from "@clayui/popover"' instead?
[exec] ../../frontend-js/frontend-js-components-web/src/main/resources/META-INF/resources/translation_manager/TranslationAdminStatusLabel.tsx(6,9): error TS2614: Module '"@clayui/alert"' has no exported member 'DisplayType'. Did you mean to use 'import DisplayType from "@clayui/alert"' instead?
[exec]
[exec]
[exec] ⚙️ Running format checks on modified files...
[exec] ❌ CI checks failed.
[exec] error Command failed with exit code 1.
[exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[exec]
[exec] > Task :packageRunCheckFormat FAILED
[exec] Gradle build finished at 2025-02-26 09:25:30.112.
[exec]
[exec]
[exec] FAILURE: Build failed with an exception.
[exec]
[exec] * What went wrong:
[exec] Execution failed for task ':packageRunCheckFormat'.
[exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
[exec]
[exec] * Try: |
|
Jenkins Build:test-portal-source-format#7024 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build ID:Testray Importer:publish-testray-report#27540 |
|
SF error is known and can be ignored (will be fixed in another PR) -> liferay-frontend#4765 |
|
Fix for errors has been merged -> #5953 (comment) |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6290 Jenkins Report:jenkins-report.html Jenkins Suite:commerce-functional Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build:[master] ci:test:commerce-functional - izaera > liferay-commerce - PR#5953 - 2025-02-27[07:33:19] Testray Build ID:Testray Importer:publish-testray-report#36595 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6291 Jenkins Report:jenkins-report.html Jenkins Suite:commerce-functional Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build:[master] ci:test:commerce-functional - izaera > liferay-commerce - PR#5953 - 2025-02-27[07:43:06] Testray Build ID:Testray Importer:publish-testray-report#36599 |
|
ci:report:152684760 |
Build completed.Testray CSV has been generated successfully for testrayBuildID: 152684760. Job Link: generate-testray-csv Testray CSV Link: testray-results-152684760.csv |
liferay-continuous-integration
added
ci:test - success
and removed
ci:test - pending
labels
|
ci:test:relevant |
|
ci:test:stable |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#12709 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - izaera > liferay-commerce - PR#5953 - 2025-02-28[06:02:43] Testray Build ID:Testray Importer:publish-testray-report#27782 |
✔️ ci:test:stable - 32 out of 32 jobs passed in 2 hours 31 minutesClick here for more details.Base Branch:Branch Name: master ci:test:stable - 32 out of 32 jobs PASSED32 Successful Jobs:
For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#11932 Jenkins Report:jenkins-report.html Jenkins Suite:stable Pull Request:liferay-commerce#5953 Testray Routine:EE Pull Request Testray Build ID:Testray Importer:publish-testray-report#24598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team 👋
This PR is part of LPD-47718.
It refactors your code to import
openModal,openToast, etc. fromfrontend-js-components-webinstead offrontend-js-web.The final goal is to remove those methods from
frontend-js-webso that whenever that module is imported the browser doesn't need to pull React and Clay simply because those methods existed there. This will enhance the performance of sites that don't need React or Clay.Internally, for now, we are only re-exporting those methods from
frontend-js-components-web, but once all PRs like this one sent to teams are merged, we (Frontend Infra) will send another final PR to move the methods and remove them completely fromfrontend-js-web.The code in this PR (as well as the one we will send to other teams) has been thoroughly tested in this PR but we want to make sure that it doesn't break anything and that's why we send it to you for review.
The expectations are that you run the tests suites you think apply and if nothing breaks you just simply forward the PR to Brian.
Also, it would be great if any new code you write that uses those methods imports them from
frontend-js-components-webinstead offrontend-js-webso that we don't have to repeat this process again 😬 .For reference, here is the list of moved methods: