bypass LibXML::Node:D raku() built-in method

Lessen impact of #95.
libxml-raku · Feb 19, 2023 · 54c6ee1 · 54c6ee1
1 parent e48ba34
commit 54c6ee1
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,16 @@
 {{$NEXT}}
-   - Add elementIndex method to LibXML::Element. This is valid
-     and non-zero after invoking doc.indexElements().
+   - Lessen impact of #95 (.raku method handing). Override LibXML::Node:D
+     raku() to call LibXML::Node:U raku().
+   - Add intermediate domNode() role. This eases class composition
+     and bypasses the need to nativecast raw nodes, when the type
+     is known in advance. E.g. getElementsByTagName() is about
+     25% faster.
+   - Further optimize LibXML::Node::Set by nativecasting a CArray
+     as a whole to the container type, rather than casting individual
+     members.
+   - Add elementIndex() method to LibXML::Element. After invoking
+     doc.indexElements(), this returns distinct element numbers,
+     with the root element having value 1.
    - Change xmlElement content() access to return a string. This
      is where the element-index (above) is stored.
    - Lock-protect error handling.

diff --git a/lib/LibXML/Node.rakumod b/lib/LibXML/Node.rakumod
@@ -169,6 +169,11 @@ multi method box(anyNode:D $node, *%c) {
     $class.bless: :raw($node.delegate), |%c;
 }
 
+multi method raku(::?CLASS:D: $obj?) {
+    # issue #95
+    self.WHAT.raku;
+}
+
 method getName { self.getNodeName }
 
 #| Gets or sets the node name

diff --git a/t/issue#095.t b/t/issue#095.t
@@ -0,0 +1,20 @@
+use v6;
+use LibXML;
+use LibXML::Element;
+use Test;
+plan 1;
+
+my $html = q:to/XML/;
+<body>
+<anElem/>
+Some text
+</body>
+XML
+
+my LibXML $parser .= new;
+my $doc = $parser.parse(
+    :string($html),
+    :!blanks,
+);
+
+throws-like { for $doc.root.childNodes -> LibXML::Element $re {} }, X::TypeCheck::Binding::Parameter;