Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for release 1.2.61? #286

Closed
hartwork opened this issue Mar 21, 2023 · 21 comments
Closed

Plans for release 1.2.61? #286

hartwork opened this issue Mar 21, 2023 · 21 comments
Assignees
Milestone

Comments

@hartwork
Copy link

Hi!

It will soon be five months since the latest release 1.2.60 and there are fixes on master since then that users will be happy about. Are there any plans for a release 1.2.61?

Thanks and best, Sebastian

@icculus
Copy link
Collaborator

icculus commented Mar 21, 2023

Yeah, this has been pending...I'll see if I can get a release out this week, if possible!

@hartwork
Copy link
Author

Cool! 👍

@DominusExult
Copy link

Just to chime in, would it be possible to add a release dll for Windows next time?
I just had the discussion with someone and thought I could just point him here, let him grab the dll, then the SDL2 dll and he would be good :(

@icculus
Copy link
Collaborator

icculus commented Apr 24, 2023

Just to chime in, would it be possible to add a release dll for Windows next time?

CC @slouken: is this something we can reasonably do from the same place you generate SDL release binaries? I don't know if that's easy or complicated.

@slouken
Copy link
Collaborator

slouken commented Apr 24, 2023

Possibly, I'll take a look. How do you currently create the release?

@icculus icculus added this to the 1.2.64 milestone May 14, 2023
@icculus icculus self-assigned this May 14, 2023
@icculus
Copy link
Collaborator

icculus commented May 14, 2023

How do you currently create the release?

I think we've just been tagging it in git and telling GitHub "this tag is the release's commit" and letting it build a tarball. I don't think we've done builds for any platform so far, just source code.

@Conan-Kudo
Copy link
Contributor

Fedora is building MinGW/Windows builds for sdl12-compat for cross compiling SDL applications to Windows. So at least I know it works. 😄

@slouken
Copy link
Collaborator

slouken commented May 17, 2023

Yeah, let me know when you're getting close to release, and I'll set up a Windows DLL build here.

@icculus
Copy link
Collaborator

icculus commented May 18, 2023

Okay, I'm going to tag a prerelease 1.2.62 today, which will become a 1.2.64 stable release about a week later.

@sezero, do you have anything you want to do before I set the prerelease tag?

@icculus
Copy link
Collaborator

icculus commented May 18, 2023

Also CC @sulix, in case you have anything pending you want to get into this release.

@sezero
Copy link
Contributor

sezero commented May 18, 2023

@sezero, do you have anything you want to do before I set the prerelease tag?

Not particularly.

Does #216 has a change of getting fixed before release?

@icculus
Copy link
Collaborator

icculus commented May 18, 2023

Does #216 has a change of getting fixed before release?

It felt too risky, considering last time it broke dozens of games.

That fork of quake2 isn't popular, so it's not high-priority. We'll try to fix it for the next release.

@icculus
Copy link
Collaborator

icculus commented May 18, 2023

Okay, 1.2.62 PRERELEASE is live: https://github.com/libsdl-org/sdl12-compat/releases/tag/prerelease-1.2.62

The git repo now reports itself as 1.2.63 and will bump to .64 for the official release. We'll let this marinate for a week or so before the release.

@slouken, you can add Windows DLLs to this here and look for the thing about attaching files at the bottom of that page, if you want to take a shot at building those.

@slouken
Copy link
Collaborator

slouken commented May 18, 2023

Windows DLLs built and added to the release!

@sulix
Copy link
Contributor

sulix commented May 19, 2023

Also CC @sulix, in case you have anything pending you want to get into this release.

Nothing on my end.

There was an audio regression on Uplink, but it turned out to be an sdl2-compat issue (libsdl-org/sdl2-compat#75), and doesn't reproduce with sdl12-compat on top of real SDL2.

@icculus
Copy link
Collaborator

icculus commented May 25, 2023

Last call on this, probably releasing 1.2.64 today if there are no objections.

@icculus
Copy link
Collaborator

icculus commented May 25, 2023

Tagging release in 60 minutes.

@icculus
Copy link
Collaborator

icculus commented May 26, 2023

image

I see this is still running on Icculus Time. :)

This is officially released!

https://github.com/libsdl-org/sdl12-compat/releases/tag/release-1.2.64

@slouken, feel free to build Windows .dlls if you want to add them to the release.

I have bumped revision control to 1.2.65, which will someday become a 1.2.66 prerelease and an official 1.2.68, if it works hard in school and eats its vegetables. But for now, this issue can be closed! Thanks everyone!

@icculus icculus closed this as completed May 26, 2023
@icculus
Copy link
Collaborator

icculus commented May 26, 2023

(Also, CC @Conan-Kudo, for pulling the new release into Fedora at his leisure.)

@hartwork
Copy link
Author

Thanks for making this happen! 🙏

@slouken
Copy link
Collaborator

slouken commented May 26, 2023

Windows binaries are up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants