Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): handle pre-release version #5886

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Feb 24, 2025

Description

Include pre-release suffix when comparing released vs current version in our CI script.

Notes & open questions

Caused https://github.com/libp2p/rust-libp2p/actions/runs/13444113668/job/37565385750?pr=5854 to fail because the -alpha suffix was ignored.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elena! LGTM

@mergify mergify bot merged commit 07072c2 into libp2p:master Feb 25, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants