feat(relay): emit event when client connections are dropped #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
close_reservation_on_zero_conn
branch
2 times, most recently
from
7f11002 to
1664632
Compare
elenaf9
reviewed
Feb 19, 2025
RolandSherwin
force-pushed
the
close_reservation_on_zero_conn
branch
2 times, most recently
from
ff5da99 to
961b273
Compare
elenaf9
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
One nit about the changelog entry, rest LGTM.
Thanks @RolandSherwin!
RolandSherwin
force-pushed
the
close_reservation_on_zero_conn
branch
from
bfd945b to
8fc7efe
Compare
elenaf9
reviewed
Feb 25, 2025
RolandSherwin
force-pushed
the
close_reservation_on_zero_conn
branch
from
8fc7efe to
4b4e462
Compare
RolandSherwin
changed the title
elenaf9
previously approved these changes
Feb 25, 2025
|
Ah sorry, metrics also needs version bump (only patch version though) and changelog entry. |
RolandSherwin
force-pushed
the
close_reservation_on_zero_conn
branch
from
a9efc87 to
39ec7d5
Compare
|
No worries! I've pushed the changes there. @elenaf9 |
mergify
bot
dismissed
elenaf9’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
dariusc93
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a relay server has no more connection with a reserved client, it would remove the reservation and the drop the circuits without any information passed to the server. It will be useful to for a server to track all its reservations and to know when they're removed (without keeping track of the connections themselves).
This PR aims to notify the server when a reservation closes, with the emission of the following event
Change checklist